You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by Dan Kirkwood <da...@apache.org> on 2017/08/08 21:39:07 UTC
Pull Request Builder on Apache Jenkins
Hi all... We have projects in the Apache Jenkins server under this
folder: https://builds.apache.org/view/S-Z/view/TrafficControl/
I've added a new project there to build new PR:
https://builds.apache.org/view/S-Z/view/TrafficControl/job/incubator-trafficcontrol-PR/
Details below, and also documented in the description at the top of that page.
Questions/Concerns? Please follow up to the dev mailing list here.
-dan
---------------------------------------------
When a new pull request is opened in the project, it will build
automatically if the author is already whitelisted.
If the author is not white-listed, builder will ask (in PR comments)
"Can one of the admins verify this patch?". Any committer can respond
in the PR comments:
"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist
If the build fails for other various reasons you can rebuild:
"retest this please" to start a new build
Re: Pull Request Builder on Apache Jenkins
Posted by Dan Kirkwood <da...@gmail.com>.
If you care to see what this plugin can do, it's documented here:
https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin
On Tue, Aug 8, 2017 at 3:59 PM, Dan Kirkwood <da...@gmail.com> wrote:
> looks like it will skip if the title contains [skipXXXci] where XXX is
> any non-whitespace.. Not sure why that form, but it's possible.
>
> I'll wait for other feedback before making any change to that.
Re: Pull Request Builder on Apache Jenkins
Posted by Dan Kirkwood <da...@gmail.com>.
looks like it will skip if the title contains [skipXXXci] where XXX is
any non-whitespace.. Not sure why that form, but it's possible.
I'll wait for other feedback before making any change to that.
Re: Pull Request Builder on Apache Jenkins
Posted by Dan Kirkwood <da...@gmail.com>.
the former indicates any commits to this PR will cause a new build to
happen. The latter is one time only.
On Tue, Aug 8, 2017 at 3:48 PM, Phil Sorber <so...@apache.org> wrote:
>> "ok to test" to accept this pull request for testing
>> "test this please" for a one time test run
>
> What is the difference between these two?
>
> On Tue, Aug 8, 2017 at 3:46 PM Volz, Dylan (Contractor) <
> Dylan_Volz@comcast.com> wrote:
>
>> Perhaps it could check for WIP prefix to prevent noisy(?) failures on
>> incomplete work?
>>
>> On 8/8/17, 3:39 PM, "Dan Kirkwood" <da...@apache.org> wrote:
>>
>> Hi all... We have projects in the Apache Jenkins server under this
>> folder: https://builds.apache.org/view/S-Z/view/TrafficControl/
>>
>> I've added a new project there to build new PR:
>>
>> https://builds.apache.org/view/S-Z/view/TrafficControl/job/incubator-trafficcontrol-PR/
>>
>> Details below, and also documented in the description at the top of
>> that page.
>>
>> Questions/Concerns? Please follow up to the dev mailing list here.
>>
>> -dan
>>
>> ---------------------------------------------
>> When a new pull request is opened in the project, it will build
>> automatically if the author is already whitelisted.
>>
>> If the author is not white-listed, builder will ask (in PR comments)
>> "Can one of the admins verify this patch?". Any committer can respond
>> in the PR comments:
>>
>> "ok to test" to accept this pull request for testing
>> "test this please" for a one time test run
>> "add to whitelist" to add the author to the whitelist
>>
>> If the build fails for other various reasons you can rebuild:
>>
>> "retest this please" to start a new build
>>
>>
>>
>>
Re: Pull Request Builder on Apache Jenkins
Posted by Phil Sorber <so...@apache.org>.
> "ok to test" to accept this pull request for testing
> "test this please" for a one time test run
What is the difference between these two?
On Tue, Aug 8, 2017 at 3:46 PM Volz, Dylan (Contractor) <
Dylan_Volz@comcast.com> wrote:
> Perhaps it could check for WIP prefix to prevent noisy(?) failures on
> incomplete work?
>
> On 8/8/17, 3:39 PM, "Dan Kirkwood" <da...@apache.org> wrote:
>
> Hi all... We have projects in the Apache Jenkins server under this
> folder: https://builds.apache.org/view/S-Z/view/TrafficControl/
>
> I've added a new project there to build new PR:
>
> https://builds.apache.org/view/S-Z/view/TrafficControl/job/incubator-trafficcontrol-PR/
>
> Details below, and also documented in the description at the top of
> that page.
>
> Questions/Concerns? Please follow up to the dev mailing list here.
>
> -dan
>
> ---------------------------------------------
> When a new pull request is opened in the project, it will build
> automatically if the author is already whitelisted.
>
> If the author is not white-listed, builder will ask (in PR comments)
> "Can one of the admins verify this patch?". Any committer can respond
> in the PR comments:
>
> "ok to test" to accept this pull request for testing
> "test this please" for a one time test run
> "add to whitelist" to add the author to the whitelist
>
> If the build fails for other various reasons you can rebuild:
>
> "retest this please" to start a new build
>
>
>
>
Re: Pull Request Builder on Apache Jenkins
Posted by "Volz, Dylan (Contractor)" <Dy...@comcast.com>.
Perhaps it could check for WIP prefix to prevent noisy(?) failures on incomplete work?
On 8/8/17, 3:39 PM, "Dan Kirkwood" <da...@apache.org> wrote:
Hi all... We have projects in the Apache Jenkins server under this
folder: https://builds.apache.org/view/S-Z/view/TrafficControl/
I've added a new project there to build new PR:
https://builds.apache.org/view/S-Z/view/TrafficControl/job/incubator-trafficcontrol-PR/
Details below, and also documented in the description at the top of that page.
Questions/Concerns? Please follow up to the dev mailing list here.
-dan
---------------------------------------------
When a new pull request is opened in the project, it will build
automatically if the author is already whitelisted.
If the author is not white-listed, builder will ask (in PR comments)
"Can one of the admins verify this patch?". Any committer can respond
in the PR comments:
"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist
If the build fails for other various reasons you can rebuild:
"retest this please" to start a new build