[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1581: [CELEBORN-669] Avoid commit files on excluded worker list

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1581:
URL: https://github.com/apache/incubator-celeborn/pull/1581#discussion_r1228185737


##########
client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala:
##########
@@ -265,14 +266,29 @@ abstract class CommitHandler(
           slaveIds,
           getMapperAttempts(shuffleId),
           commitEpoch.incrementAndGet())
-        val res = requestCommitFilesWithRetry(worker.endpoint, commitFiles)
+        val res =

Review Comment:
   > If worker in blacklist, we can fast return commitFiles at the very beginning of the method
   
   We can't return. In fact we need to construct a ```CommitFilesResponse``` with proper ```failedMasterIds``` and ```failedSlaveIds```.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org