You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/13 07:38:19 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4398: fix(tapd): convert unicode to string
warren830 opened a new pull request, #4398:
URL: https://github.com/apache/incubator-devlake/pull/4398
### Summary
Convert unicode to string when extracting story changelogs
### Does this close any open issues?
Part of #4394 4394
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4398: fix(tapd): cherrypick from #4399 to hexun-tapd
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on code in PR #4398:
URL: https://github.com/apache/incubator-devlake/pull/4398#discussion_r1104110702
##########
plugins/tapd/tasks/story_changelog_extractor.go:
##########
@@ -119,3 +129,24 @@ func ExtractStoryChangelog(taskCtx core.SubTaskContext) errors.Error {
return extractor.Execute()
}
+
+func unicodeToZh(s string) (string, error) {
+ str, err := strconv.Unquote(strings.Replace(strconv.Quote(s), `\\u`, `\u`, -1))
Review Comment:
Ok, I will add comment to main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4398: fix(tapd): cherrypick from #4399 to hexun-tapd
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #4398:
URL: https://github.com/apache/incubator-devlake/pull/4398#discussion_r1104110035
##########
plugins/tapd/tasks/story_changelog_extractor.go:
##########
@@ -119,3 +129,24 @@ func ExtractStoryChangelog(taskCtx core.SubTaskContext) errors.Error {
return extractor.Execute()
}
+
+func unicodeToZh(s string) (string, error) {
+ str, err := strconv.Unquote(strings.Replace(strconv.Quote(s), `\\u`, `\u`, -1))
Review Comment:
you want to only unquote `\uXXXX` ？ Would you like add a comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4398: fix(tapd): cherrypick from #4399 to hexun-tapd
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 merged PR #4398:
URL: https://github.com/apache/incubator-devlake/pull/4398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org