You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2017/02/24 10:06:00 UTC
Review Request 57026: Cover NameNode HA wizard with unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57026/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-20165
https://issues.apache.org/jira/browse/AMBARI-20165
Repository: ambari
Description
-------
Cover NameNode HA wizard with unit tests
Diffs
-----
ambari-web/app/assets/test/tests.js 05c1657
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js 435fe0f
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 0a46af7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step4_controller.js c0f688e
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 7b20439
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step6_controller.js 0ef3048
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js b98c2df
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step1_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step2_controller_test.js 570f45a
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 98d71da
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js d5ab8d2
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step5_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step6_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step9_controller_test.js PRE-CREATION
ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/57026/diff/
Testing
-------
20490 passing (33s)
153 pending
Thanks,
Andrii Tkach
Re: Review Request 57026: Cover NameNode HA wizard with unit tests
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57026/#review166694
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0424\u0435\u0432. 24, 2017, 10:05 \u0434.\u043f., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57026/
> -----------------------------------------------------------
>
> (Updated \u0424\u0435\u0432. 24, 2017, 10:05 \u0434.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20165
> https://issues.apache.org/jira/browse/AMBARI-20165
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover NameNode HA wizard with unit tests
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 05c1657
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js 435fe0f
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 0a46af7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step4_controller.js c0f688e
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 7b20439
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step6_controller.js 0ef3048
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js b98c2df
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step1_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step2_controller_test.js 570f45a
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js 98d71da
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js d5ab8d2
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step5_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step6_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/step9_controller_test.js PRE-CREATION
> ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/57026/diff/
>
>
> Testing
> -------
>
> 20490 passing (33s)
> 153 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>