[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4359: [MySQL Compatibility 1/4][Bug] Fix bug that set sql_mode with concat() function failed

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4359:
URL: https://github.com/apache/incubator-doris/pull/4359#discussion_r473690884



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java
##########
@@ -96,6 +98,14 @@ public Expr evalExpr(Expr constExpr) {
                     return constExpr;
                 }
             }
+        } else if (constExpr instanceof SysVariableDesc) {
+            try {
+                VariableMgr.fillValue(ConnectContext.get().getSessionVariable(), (SysVariableDesc) constExpr);
+                return ((SysVariableDesc) constExpr).getLiteralExpr();
+            } catch (AnalysisException e) {

Review comment:
       Why not just throw the exception to the user?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org