You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by keith2008 <gi...@git.apache.org> on 2016/08/23 01:13:50 UTC
[GitHub] trafficserver pull request #902: TS-4746: ParentRecord *secondary_parents ma...
GitHub user keith2008 opened a pull request:
https://github.com/apache/trafficserver/pull/902
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak
ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith2008/trafficserver TS-4746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #902
----
commit 8a76d21f5194cb31e514860319b8fcae2d2648be
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:42:30Z
TS-4743: parent use consistent_hash Strategy may cause crash while first parent is not set
commit 3deb52397b047455ba8aba3e5132e3daafa980ad
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:51:44Z
TS-4744: ParentConsistentHash::selectParent may select the unavailable parent
commit 49beaa5b5fd712c1d8383b081fc8479ec680ae0a
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T00:58:54Z
TS-4745: pRecord.failCount not init in ParentRecord::ProcessParents
commit 1159f47044e7add14ccaa84bf110895e244599b0
Author: keith2008 <56...@qq.com>
Date: 2016-08-23T01:12:22Z
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #902: TS-4746: ParentRecord *secondary_parents malloc, b...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/902
Closing this PR on behalf of keith2008 due to merge conflicts. I am creating a new PR for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #902: TS-4746: ParentRecord *secondary_parents ma...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford closed the pull request at:
https://github.com/apache/trafficserver/pull/902
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #902: TS-4746: ParentRecord *secondary_parents malloc, b...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/902
Just to be picky, but we should avoid typos in the commit messages (memory, not memory). I also think this could be simplified to just e.g.
4746 Fixes ParentRecord *secondary_parents memory leak
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #902: TS-4746: ParentRecord *secondary_parents malloc, b...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/902
Also, I'm pretty sure this would fail the CI build, please run "make clang-format" on the code, and push this again with the updated commit message.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #902: TS-4746: ParentRecord *secondary_parents malloc, b...
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/902
I don't think the NULL check on the pointer is required as ats_free does that under the hood.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---