svn commit: r1570020 - in /incubator/sirona/trunk: agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java core/src/main/java/org/apache/sirona/tracking/PathTracker.java

[ol...@apache.org]

Author: olamy
Date: Thu Feb 20 00:52:26 2014
New Revision: 1570020

URL: http://svn.apache.org/r1570020
Log:
remove fixed FIXME start adding javadoc

Modified:
    incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java
    incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java

Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java?rev=1570020&r1=1570019&r2=1570020&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationListener.java Thu Feb 20 00:52:26 2014
@@ -25,6 +25,9 @@ import org.apache.sirona.tracking.PathTr
 
 @Order(1)
 @AutoSet
+/**
+ * This listener is responsible to track/record class#method path using {@link org.apache.sirona.tracking.PathTracker}
+ */
 public class PathTrackingInvocationListener extends ConfigurableListener {
 
     private static final Integer PATH_TRACKER_KEY = "Sirona-path-tracker-key".hashCode();
@@ -57,6 +60,12 @@ public class PathTrackingInvocationListe
         return true;
     }
 
+    /**
+     * executed before method called to configure the start {@link org.apache.sirona.tracking.PathTracker.PathTrackingInformation}
+     * and set various thread local variable as invocation level
+     * will call {@link org.apache.sirona.tracking.PathTracker#start(org.apache.sirona.tracking.PathTracker.PathTrackingInformation)}
+     * @param context
+     */
     @Override
     public void before( AgentContext context )
     {
@@ -77,6 +86,13 @@ public class PathTrackingInvocationListe
         context.put(PATH_TRACKER_KEY, PathTracker.start(pathTrackingInformation));
     }
 
+    /**
+     *
+     * will call {@link org.apache.sirona.tracking.PathTracker#stop(org.apache.sirona.tracking.PathTracker.PathTrackingInformation)}
+     * @param context
+     * @param result
+     * @param error
+     */
     @Override
     public void after( AgentContext context, Object result, Throwable error )
     {

Modified: incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java?rev=1570020&r1=1570019&r2=1570020&view=diff
==============================================================================
--- incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java (original)
+++ incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTracker.java Thu Feb 20 00:52:26 2014
@@ -26,7 +26,7 @@ import java.util.UUID;
 import java.util.concurrent.atomic.AtomicInteger;
 
 /**
- *
+ * Contains logic to track class#method invocation path
  */
 public class PathTracker
 {
@@ -229,14 +229,12 @@ public class PathTracker
         }
 
         // FIXME get node from configuration!
-        // FIXME correctly configure the level!
         final PathTrackingEntry pathTrackingEntry =
             new PathTrackingEntry( uuid, "node", pathTrackingInformation.getClassName(), pathTrackingInformation.getMethodName(),
                                    start, ( end - start ), pathTrackingInformation.getLevel());
 
         THREAD_LOCAL_ENTRIES.get().add( pathTrackingEntry );
 
-        // FIXME: same all duration/level browsing the tree, do we need TrackingEntry or should information just be used?
         if (pathTrackingInformation.getLevel() == 1 && pathTrackingInformation.getParent() == null) { // 0 is never reached so 1 is first
             List<PathTrackingEntry> pathTrackingEntries = THREAD_LOCAL_ENTRIES.get();
             PATH_TRACKING_DATA_STORE.store( pathTrackingEntries );