[jira] [Comment Edited] (OAK-2605) Support for additional encodings needed in ReversedLinesFileReader

["Leandro Reis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356107#comment-14356107 ] 

Leandro Reis edited comment on OAK-2605 at 3/11/15 2:16 AM:
------------------------------------------------------------

@Michael Dürig, your patch correctly includes my changes. There are 3 unit tests [*] for the ReversedLinesFileReader class, I uploaded a patch to https://issues.apache.org/jira/browse/IO-471 that adds tests for the 4 encodings I added support for, as well as test files. 

[*]
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestParamFile.java
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestParamBlockSize.java

test files - http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/resources/



was (Author: lreis):
@Michael Dürig, your patch correctly includes my changes. There are 3 unit tests (*) for the ReversedLinesFileReader class, I uploaded a patch to https://issues.apache.org/jira/browse/IO-471 that adds tests for the 4 encodings I added support for, as well as test files. 

(*)
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestSimple.java
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestParamFile.java
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/ReversedLinesFileReaderTestParamBlockSize.java

test files - http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/resources/


> Support for additional encodings needed in ReversedLinesFileReader
> ------------------------------------------------------------------
>
>                 Key: OAK-2605
>                 URL: https://issues.apache.org/jira/browse/OAK-2605
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>    Affects Versions: 1.1.7
>         Environment: Windows 2012 R2 Japanese
> Windows 2012 R2 Korean
> Windows 2012 R2 Simplified Chinese
> Windows 2012 R2 Traditional Chinese
>            Reporter: Leandro Reis
>            Assignee: Michael Dürig
>             Fix For: 1.1.8
>
>         Attachments: OAK-2605.patch
>
>
> I'm working on a product that uses Commons IO via Jackrabbit Oak. In the process of testing the launch of such product on Japanese Windows 2012
> Server R2, I came across the following exception: "(java.io.UnsupportedEncodingException: Encoding windows-31j is not supported yet (feel free to submit a patch))"
> windows-31j is the IANA name for Windows code page 932 (Japanese), and is returned by Charset.defaultCharset(), used in org.apache.commons.io.input.ReversedLinesFileReader [0].
> A patch for this issue was provided in https://issues.apache.org/jira/browse/IO-471 .  
> It also includes changes needed to support Chinese Simplified, Chinese Traditional and Korean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)