You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/18 22:13:42 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #12134: [Cosmetic][SQL Lab] Don't capitalize SQL Lab tabs
ktmud opened a new issue #12134:
URL: https://github.com/apache/incubator-superset/issues/12134
## Screenshot
#### Current
<img src="https://user-images.githubusercontent.com/335541/102665957-b4133b80-413a-11eb-8ffe-604157faa5db.png" width="600">
#### Proposed
<img src="https://user-images.githubusercontent.com/335541/102665928-a5c51f80-413a-11eb-9c91-695e7cdf754e.png" width="500">
## Description
We shouldn't capitalize user inputs. If it makes sense for users to capitalize, they will do it themselves!
This thing is tiny but following is the actual feedback we get from users when we did the same for dashboard tabs:
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12134: [Cosmetic][SQL Lab] Don't capitalize SQL Lab tabs
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12134:
URL: https://github.com/apache/incubator-superset/issues/12134#issuecomment-748347006
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Steejay commented on issue #12134: [Cosmetic][SQL Lab] Don't capitalize SQL Lab tabs
Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #12134:
URL: https://github.com/apache/incubator-superset/issues/12134#issuecomment-749782945
Agreed @ktmud. Tab names should not force all caps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org