You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/18 09:32:16 UTC
[GitHub] [flink] luoyuxia opened a new pull request, #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
luoyuxia opened a new pull request, #20016:
URL: https://github.com/apache/flink/pull/20016
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Make hive source support filter push down for orc format
## Brief change log
- Make HiveTableSource implement `SupportsFilterPushDown`
- Pass the OrcFilter to ORCRowInputFormat
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036848127
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
@luoyuxia what if to add a method to indenify format in HiveTableSource, and when implement applyFilter, we can get this format info, so to better implement applyFilter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036585698
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
Is this unimplemented to support orc filter pushdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036655683
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
What if the underlying format is text? If we remove it from the original filters, it will bring wrong result since text format don't support filter pushdown . The hard is we can't know what's the underlying format in plan phase currently though we can propose some new interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20016:
URL: https://github.com/apache/flink/pull/20016#issuecomment-1159410389
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "83ee6c72efbdbc39f12e2847b43a4565b70f877d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83ee6c72efbdbc39f12e2847b43a4565b70f877d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83ee6c72efbdbc39f12e2847b43a4565b70f877d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036606895
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
Yes, you're right. We just pushdown the orc filter to orc input format.
The reason is some formats don't implement filter pushdown or don't support filter pushdown. So, we still make the plan keep all the filters, which can make sure the result is correct.
I think i'll be better to prun hese filtres in here, but it's hard/impossible to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1037722863
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
I don't think indenify format in HiveTableSource is possible considering different partitions may have different formats and we don't know which partitions it expect to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036653155
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
@luoyuxia Thanks for reply. I also want to know what's the hard part, if the filter can pushed to orc, maybe we can remove it from the original filters, it may be more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1043332661
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
@luoyuxia I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lsyldliu commented on pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
lsyldliu commented on PR #20016:
URL: https://github.com/apache/flink/pull/20016#issuecomment-1276917202
@luoyuxia Can you help rebase the latest master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036589167
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
or now we just pushdown the orc filter to orc input format, but at planner level, we keep all the filter above the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036606895
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
Yes, you're right. We just pushdown the orc filter to orc input format.
The reason is some formats don't implement filter pushdown or don't support filter pushdown. So, we still make the plan keep all the filters, which can make sure the result is correct.
I think i'll be better to prun these filters in here, but it's hard/impossible to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org