You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/14 03:22:44 UTC
[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new pull request #52: [ISSUE #50]Modify the suffix of the interface name.
zhangjidi2016 opened a new pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52
## What is the purpose of the change
Modify the suffix of the interface. The query type is .query and the operation type is .do
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on pull request #52: [ISSUE #50]Modify the suffix of the interface name.
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52#issuecomment-993325663
@zhangjidi2016 It seems you have not activated your apache committer account, @duhenglucky or @RongtongJin will help you. After that, you could merge this when at least 2 approvers got reached:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #52: [ISSUE #50]Modify the suffix of the interface name.
Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52#discussion_r769526793
##########
File path: src/main/java/org/apache/rocketmq/dashboard/controller/DlqMessageController.java
##########
@@ -83,7 +83,7 @@ public Object batchResendDlqMessage(@RequestBody List<DlqMessageRequest> dlqMess
return dlqMessageService.batchResendDlqMessage(dlqMessages);
}
- @PostMapping(value = "/batchExportDlqMessage.query")
+ @PostMapping(value = "/batchExportDlqMessage.do")
Review comment:
The exportDlqMessage uses the get request for easy export in dlqMessage.js using window.location.href
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #52: [ISSUE #50]Modify the suffix of the interface name.
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52#discussion_r769400917
##########
File path: src/main/java/org/apache/rocketmq/dashboard/controller/DlqMessageController.java
##########
@@ -83,7 +83,7 @@ public Object batchResendDlqMessage(@RequestBody List<DlqMessageRequest> dlqMess
return dlqMessageService.batchResendDlqMessage(dlqMessages);
}
- @PostMapping(value = "/batchExportDlqMessage.query")
+ @PostMapping(value = "/batchExportDlqMessage.do")
Review comment:
`exportDlqMessage` is `Get` but `batchExportDlqMessage` is `Post`, they are similar things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang merged pull request #52: [ISSUE #50]Modify the suffix of the interface name.
Posted by GitBox <gi...@apache.org>.
StyleTang merged pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #52: [ISSUE #50]Modify the suffix of the interface name.
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #52:
URL: https://github.com/apache/rocketmq-dashboard/pull/52#discussion_r769672667
##########
File path: src/main/resources/role-permission.yml
##########
@@ -34,4 +34,4 @@ rolePerms:
- /monitor/*.query
- /consumer/*.query
- /cluster/*.query
- - /dlqMessage/*.query
+ - /dlqMessage/**
Review comment:
How about using this.
```
- /dlqMessage/*.query
- /dlqMessage/exportDlqMessage.do
- /dlqMessage/batchExportDlqMessage.do
```
Because there may be write operations in this controller, e.g. `/batchResendDlqMessage.do`, ordinary users should not have write permission by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org