You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "chitralverma (via GitHub)" <gi...@apache.org> on 2025/10/28 12:51:07 UTC

[PR] feature:(bindings/python) Enable left out services [opendal]

chitralverma opened a new pull request, #6745:
URL: https://github.com/apache/opendal/pull/6745

   # Which issue does this PR close?
   
   None
   
   # Rationale for this change
   
   This is the last one for all refactoring of python bindings in order to get things up to date with core.
   
   # What changes are included in this PR?
   
   - The PR adds the following features to python bindings
     - 
   - stable sort the configs in odev to ensure big git diffs dont happen
   
   # Are there any user-facing changes?
   
   No changes to existing APIs but this enables new services in py bindings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feature:(bindings/python) Enable left out services [opendal]

Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6745:
URL: https://github.com/apache/opendal/pull/6745#discussion_r2469501638


##########
bindings/python/Cargo.toml:
##########
@@ -49,106 +49,126 @@ default = [
 # When enable or disable some features,
 # Also, you need to update the `enabled_service` function in dev/src/generate/python.rs to match it.
 services-all = [
-  "default",
-  "services-aliyun-drive",
-  "services-azfile",
-  "services-cacache",
-  "services-dashmap",
-  "services-dropbox",
-  # FIXME this service need protoc
-  # "services-etcd",
-  # FIXME this requires a preinstalled fdb library
-  # "services-foundationdb",
-  # "services-ftp",
-  "services-gdrive",
-  # FIXME how to support HDFS services in bindings?
-  # "services-hdfs",
-  # "services-hdfs-native",
-  "services-huggingface",
-  "services-ipfs",
-  "services-memcached",
-  "services-mini-moka",
-  "services-moka",
-  "services-onedrive",
-  "services-persy",
-  "services-postgresql",
-  "services-mysql",
-  "services-redb",
-  "services-redis",
-  # FIXME how to support rocksdb services in bindings?
-  # "services-rocksdb",
-  "services-sled",
-  "services-swift",
-  # FIXME this service need protoc
-  # "services-tikv",
-  "services-vercel-artifacts",
-  "services-mongodb",
-  "services-gridfs",
-  "services-sqlite",
-  "services-alluxio",
-  "services-b2",
-  "services-seafile",
-  "services-upyun",
-  "services-koofr",
-  "services-yandex-disk",
+  'default',
+  'services-aliyun-drive',
+  'services-alluxio',
+  'services-azfile',
+  'services-b2',
+  'services-cacache',
+  'services-cloudflare-kv',
+  'services-compfs',
+  'services-d1',
+  'services-dashmap',
+  'services-dbfs',
+  'services-dropbox',
+  'services-ftp',
+  'services-gdrive',
+  'services-github',
+  'services-gridfs',
+  'services-hdfs-native',
+  'services-huggingface',
+  'services-ipfs',
+  'services-koofr',
+  'services-lakefs',
+  'services-memcached',
+  'services-mini-moka',
+  'services-moka',
+  'services-mongodb',
+  'services-monoiofs',
+  'services-mysql',
+  'services-onedrive',
+  'services-opfs',
+  'services-pcloud',
+  'services-persy',
+  'services-postgresql',
+  'services-redb',
+  'services-redis',
+  'services-seafile',
+  'services-sftp',
+  'services-sled',
+  'services-sqlite',
+  'services-surrealdb',
+  'services-swift',
+  'services-upyun',
+  'services-vercel-artifacts',
+  'services-vercel-blob',
+  'services-yandex-disk',
 ]
 
-# Default services provided by opendal.
+# List of feature-flags for all services provided by opendal.
 services-aliyun-drive = ["opendal/services-aliyun-drive"]
+services-alluxio = ["opendal/services-alluxio"]
 services-azblob = ["opendal/services-azblob"]
 services-azdls = ["opendal/services-azdls"]
-services-cos = ["opendal/services-cos"]
-services-fs = ["opendal/services-fs"]
-services-gcs = ["opendal/services-gcs"]
-services-ghac = ["opendal/services-ghac"]
-services-http = ["opendal/services-http"]
-services-ipmfs = ["opendal/services-ipmfs"]
-services-memory = ["opendal/services-memory"]
-services-obs = ["opendal/services-obs"]
-services-oss = ["opendal/services-oss"]
-services-s3 = ["opendal/services-s3"]
-services-webdav = ["opendal/services-webdav"]
-services-webhdfs = ["opendal/services-webhdfs"]
-
-# Optional services provided by opendal.
-services-alluxio = ["opendal/services-alluxio"]
 services-azfile = ["opendal/services-azfile"]
 services-b2 = ["opendal/services-b2"]
 services-cacache = ["opendal/services-cacache"]

Review Comment:
   only sorted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feature:(bindings/python) Enable left out services [opendal]

Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6745:
URL: https://github.com/apache/opendal/pull/6745#discussion_r2469497599


##########
bindings/python/python/opendal/operator.pyi:
##########


Review Comment:
   these big diffs are because previously no sorting was in place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feature:(bindings/python) Enable left out services [opendal]

Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6745:
URL: https://github.com/apache/opendal/pull/6745#discussion_r2469502594


##########
bindings/python/Cargo.toml:
##########
@@ -49,106 +49,126 @@ default = [
 # When enable or disable some features,
 # Also, you need to update the `enabled_service` function in dev/src/generate/python.rs to match it.
 services-all = [
-  "default",
-  "services-aliyun-drive",
-  "services-azfile",
-  "services-cacache",
-  "services-dashmap",
-  "services-dropbox",
-  # FIXME this service need protoc
-  # "services-etcd",
-  # FIXME this requires a preinstalled fdb library
-  # "services-foundationdb",
-  # "services-ftp",
-  "services-gdrive",
-  # FIXME how to support HDFS services in bindings?
-  # "services-hdfs",
-  # "services-hdfs-native",
-  "services-huggingface",
-  "services-ipfs",
-  "services-memcached",
-  "services-mini-moka",
-  "services-moka",
-  "services-onedrive",
-  "services-persy",
-  "services-postgresql",
-  "services-mysql",
-  "services-redb",
-  "services-redis",
-  # FIXME how to support rocksdb services in bindings?
-  # "services-rocksdb",
-  "services-sled",
-  "services-swift",
-  # FIXME this service need protoc
-  # "services-tikv",
-  "services-vercel-artifacts",
-  "services-mongodb",
-  "services-gridfs",
-  "services-sqlite",
-  "services-alluxio",
-  "services-b2",
-  "services-seafile",
-  "services-upyun",
-  "services-koofr",
-  "services-yandex-disk",
+  'default',
+  'services-aliyun-drive',
+  'services-alluxio',
+  'services-azfile',
+  'services-b2',
+  'services-cacache',
+  'services-cloudflare-kv',
+  'services-compfs',
+  'services-d1',
+  'services-dashmap',
+  'services-dbfs',
+  'services-dropbox',
+  'services-ftp',
+  'services-gdrive',
+  'services-github',
+  'services-gridfs',
+  'services-hdfs-native',
+  'services-huggingface',
+  'services-ipfs',
+  'services-koofr',
+  'services-lakefs',
+  'services-memcached',
+  'services-mini-moka',
+  'services-moka',
+  'services-mongodb',
+  'services-monoiofs',
+  'services-mysql',
+  'services-onedrive',
+  'services-opfs',
+  'services-pcloud',
+  'services-persy',
+  'services-postgresql',
+  'services-redb',
+  'services-redis',
+  'services-seafile',
+  'services-sftp',
+  'services-sled',
+  'services-sqlite',
+  'services-surrealdb',
+  'services-swift',
+  'services-upyun',
+  'services-vercel-artifacts',
+  'services-vercel-blob',
+  'services-yandex-disk',
 ]
 
-# Default services provided by opendal.
+# List of feature-flags for all services provided by opendal.
 services-aliyun-drive = ["opendal/services-aliyun-drive"]
+services-alluxio = ["opendal/services-alluxio"]
 services-azblob = ["opendal/services-azblob"]
 services-azdls = ["opendal/services-azdls"]
-services-cos = ["opendal/services-cos"]
-services-fs = ["opendal/services-fs"]
-services-gcs = ["opendal/services-gcs"]
-services-ghac = ["opendal/services-ghac"]
-services-http = ["opendal/services-http"]
-services-ipmfs = ["opendal/services-ipmfs"]
-services-memory = ["opendal/services-memory"]
-services-obs = ["opendal/services-obs"]
-services-oss = ["opendal/services-oss"]
-services-s3 = ["opendal/services-s3"]
-services-webdav = ["opendal/services-webdav"]
-services-webhdfs = ["opendal/services-webhdfs"]
-
-# Optional services provided by opendal.
-services-alluxio = ["opendal/services-alluxio"]
 services-azfile = ["opendal/services-azfile"]
 services-b2 = ["opendal/services-b2"]
 services-cacache = ["opendal/services-cacache"]
+services-cloudflare-kv = ["opendal/services-cloudflare-kv"]
 services-compfs = ["opendal/services-compfs"]
+services-cos = ["opendal/services-cos"]
+services-d1 = ["opendal/services-d1"]
 services-dashmap = ["opendal/services-dashmap"]
+services-dbfs = ["opendal/services-dbfs"]
 services-dropbox = ["opendal/services-dropbox"]
-services-etcd = ["opendal/services-etcd"]
-services-foundationdb = ["opendal/services-foundationdb"]
+services-etcd = [
+  "opendal/services-etcd",
+] # FIXME EXCLUDED: this service needs protoc
+services-foundationdb = [
+  "opendal/services-foundationdb",
+] # FIXME EXCLUDED: this service needs preinstalled fdb library
+services-fs = ["opendal/services-fs"]
 services-ftp = ["opendal/services-ftp"]
+services-gcs = ["opendal/services-gcs"]
 services-gdrive = ["opendal/services-gdrive"]
+services-ghac = ["opendal/services-ghac"]
+services-github = ["opendal/services-github"]
 services-gridfs = ["opendal/services-gridfs"]
-services-hdfs = ["opendal/services-hdfs"]
+services-hdfs = [
+  "opendal/services-hdfs",
+] # FIXME EXCLUDED: how to support HDFS services in bindings?
 services-hdfs-native = ["opendal/services-hdfs-native"]
+services-http = ["opendal/services-http"]
 services-huggingface = ["opendal/services-huggingface"]
 services-ipfs = ["opendal/services-ipfs"]
+services-ipmfs = ["opendal/services-ipmfs"]
 services-koofr = ["opendal/services-koofr"]
+services-lakefs = ["opendal/services-lakefs"]
 services-memcached = ["opendal/services-memcached"]
+services-memory = ["opendal/services-memory"]
 services-mini-moka = ["opendal/services-mini-moka"]
 services-moka = ["opendal/services-moka"]
 services-mongodb = ["opendal/services-mongodb"]
 services-monoiofs = ["opendal/services-monoiofs"]
 services-mysql = ["opendal/services-mysql"]
+services-obs = ["opendal/services-obs"]
 services-onedrive = ["opendal/services-onedrive"]
+services-opfs = ["opendal/services-opfs"]
+services-oss = ["opendal/services-oss"]
+services-pcloud = ["opendal/services-pcloud"]
 services-persy = ["opendal/services-persy"]
 services-postgresql = ["opendal/services-postgresql"]
 services-redb = ["opendal/services-redb"]
-services-redis = ["opendal/services-redis"]
-services-rocksdb = ["opendal/services-rocksdb"]
+services-redis = ["opendal/services-redis", "opendal/services-redis-native-tls"]

Review Comment:
   included `services-redis-native-tls`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(bindings/python): Enable ftp/hdfs_native/sftp for python [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6745:
URL: https://github.com/apache/opendal/pull/6745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feature:(bindings/python) Enable left out services [opendal]

Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6745:
URL: https://github.com/apache/opendal/pull/6745#discussion_r2469504727


##########
bindings/python/Cargo.toml:
##########
@@ -49,106 +49,126 @@ default = [
 # When enable or disable some features,
 # Also, you need to update the `enabled_service` function in dev/src/generate/python.rs to match it.
 services-all = [
-  "default",
-  "services-aliyun-drive",
-  "services-azfile",
-  "services-cacache",
-  "services-dashmap",
-  "services-dropbox",
-  # FIXME this service need protoc
-  # "services-etcd",
-  # FIXME this requires a preinstalled fdb library
-  # "services-foundationdb",
-  # "services-ftp",
-  "services-gdrive",
-  # FIXME how to support HDFS services in bindings?
-  # "services-hdfs",
-  # "services-hdfs-native",
-  "services-huggingface",
-  "services-ipfs",
-  "services-memcached",
-  "services-mini-moka",
-  "services-moka",
-  "services-onedrive",
-  "services-persy",
-  "services-postgresql",
-  "services-mysql",
-  "services-redb",
-  "services-redis",
-  # FIXME how to support rocksdb services in bindings?
-  # "services-rocksdb",
-  "services-sled",
-  "services-swift",
-  # FIXME this service need protoc
-  # "services-tikv",
-  "services-vercel-artifacts",
-  "services-mongodb",
-  "services-gridfs",
-  "services-sqlite",
-  "services-alluxio",
-  "services-b2",
-  "services-seafile",
-  "services-upyun",
-  "services-koofr",
-  "services-yandex-disk",
+  'default',
+  'services-aliyun-drive',
+  'services-alluxio',
+  'services-azfile',
+  'services-b2',
+  'services-cacache',
+  'services-cloudflare-kv',
+  'services-compfs',
+  'services-d1',
+  'services-dashmap',
+  'services-dbfs',
+  'services-dropbox',
+  'services-ftp',
+  'services-gdrive',
+  'services-github',
+  'services-gridfs',
+  'services-hdfs-native',
+  'services-huggingface',
+  'services-ipfs',
+  'services-koofr',
+  'services-lakefs',
+  'services-memcached',
+  'services-mini-moka',
+  'services-moka',
+  'services-mongodb',
+  'services-monoiofs',
+  'services-mysql',
+  'services-onedrive',
+  'services-opfs',
+  'services-pcloud',
+  'services-persy',
+  'services-postgresql',
+  'services-redb',
+  'services-redis',
+  'services-seafile',
+  'services-sftp',
+  'services-sled',
+  'services-sqlite',
+  'services-surrealdb',
+  'services-swift',
+  'services-upyun',
+  'services-vercel-artifacts',
+  'services-vercel-blob',
+  'services-yandex-disk',
 ]
 
-# Default services provided by opendal.
+# List of feature-flags for all services provided by opendal.
 services-aliyun-drive = ["opendal/services-aliyun-drive"]
+services-alluxio = ["opendal/services-alluxio"]
 services-azblob = ["opendal/services-azblob"]
 services-azdls = ["opendal/services-azdls"]
-services-cos = ["opendal/services-cos"]
-services-fs = ["opendal/services-fs"]
-services-gcs = ["opendal/services-gcs"]
-services-ghac = ["opendal/services-ghac"]
-services-http = ["opendal/services-http"]
-services-ipmfs = ["opendal/services-ipmfs"]
-services-memory = ["opendal/services-memory"]
-services-obs = ["opendal/services-obs"]
-services-oss = ["opendal/services-oss"]
-services-s3 = ["opendal/services-s3"]
-services-webdav = ["opendal/services-webdav"]
-services-webhdfs = ["opendal/services-webhdfs"]
-
-# Optional services provided by opendal.
-services-alluxio = ["opendal/services-alluxio"]
 services-azfile = ["opendal/services-azfile"]
 services-b2 = ["opendal/services-b2"]
 services-cacache = ["opendal/services-cacache"]
+services-cloudflare-kv = ["opendal/services-cloudflare-kv"]
 services-compfs = ["opendal/services-compfs"]
+services-cos = ["opendal/services-cos"]
+services-d1 = ["opendal/services-d1"]
 services-dashmap = ["opendal/services-dashmap"]
+services-dbfs = ["opendal/services-dbfs"]
 services-dropbox = ["opendal/services-dropbox"]
-services-etcd = ["opendal/services-etcd"]
-services-foundationdb = ["opendal/services-foundationdb"]
+services-etcd = [
+  "opendal/services-etcd",
+] # FIXME EXCLUDED: this service needs protoc
+services-foundationdb = [
+  "opendal/services-foundationdb",
+] # FIXME EXCLUDED: this service needs preinstalled fdb library
+services-fs = ["opendal/services-fs"]
 services-ftp = ["opendal/services-ftp"]
+services-gcs = ["opendal/services-gcs"]
 services-gdrive = ["opendal/services-gdrive"]
+services-ghac = ["opendal/services-ghac"]
+services-github = ["opendal/services-github"]
 services-gridfs = ["opendal/services-gridfs"]
-services-hdfs = ["opendal/services-hdfs"]
+services-hdfs = [
+  "opendal/services-hdfs",
+] # FIXME EXCLUDED: how to support HDFS services in bindings?
 services-hdfs-native = ["opendal/services-hdfs-native"]
+services-http = ["opendal/services-http"]
 services-huggingface = ["opendal/services-huggingface"]
 services-ipfs = ["opendal/services-ipfs"]
+services-ipmfs = ["opendal/services-ipmfs"]
 services-koofr = ["opendal/services-koofr"]
+services-lakefs = ["opendal/services-lakefs"]
 services-memcached = ["opendal/services-memcached"]
+services-memory = ["opendal/services-memory"]
 services-mini-moka = ["opendal/services-mini-moka"]
 services-moka = ["opendal/services-moka"]
 services-mongodb = ["opendal/services-mongodb"]
 services-monoiofs = ["opendal/services-monoiofs"]
 services-mysql = ["opendal/services-mysql"]
+services-obs = ["opendal/services-obs"]
 services-onedrive = ["opendal/services-onedrive"]
+services-opfs = ["opendal/services-opfs"]
+services-oss = ["opendal/services-oss"]
+services-pcloud = ["opendal/services-pcloud"]
 services-persy = ["opendal/services-persy"]
 services-postgresql = ["opendal/services-postgresql"]
 services-redb = ["opendal/services-redb"]
-services-redis = ["opendal/services-redis"]
-services-rocksdb = ["opendal/services-rocksdb"]
+services-redis = ["opendal/services-redis", "opendal/services-redis-native-tls"]
+services-rocksdb = [
+  "opendal/services-rocksdb",
+] # FIXME EXCLUDED: how to support rocksdb services in bindings?
+services-s3 = ["opendal/services-s3"]
 services-seafile = ["opendal/services-seafile"]
 services-sftp = ["opendal/services-sftp"]
 services-sled = ["opendal/services-sled"]
 services-sqlite = ["opendal/services-sqlite"]
+services-surrealdb = ["opendal/services-surrealdb"]
 services-swift = ["opendal/services-swift"]
-services-tikv = ["opendal/services-tikv"]
+services-tikv = [
+  "opendal/services-tikv",
+] # FIXME EXCLUDED: this service needs protoc
 services-upyun = ["opendal/services-upyun"]
 services-vercel-artifacts = ["opendal/services-vercel-artifacts"]
+services-vercel-blob = ["opendal/services-vercel-blob"]
+services-webdav = ["opendal/services-webdav"]
+services-webhdfs = ["opendal/services-webhdfs"]
 services-yandex-disk = ["opendal/services-yandex-disk"]
+
 # we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop cp310
 abi3 = ["pyo3/abi3-py311"]

Review Comment:
   did not remove the comment over abi, but this needs to be carefully done or there will be a conflict with stubgen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feature:(bindings/python) Enable left out services [opendal]

Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6745:
URL: https://github.com/apache/opendal/pull/6745#discussion_r2469500541


##########
bindings/python/Cargo.toml:
##########
@@ -49,106 +49,126 @@ default = [
 # When enable or disable some features,
 # Also, you need to update the `enabled_service` function in dev/src/generate/python.rs to match it.
 services-all = [
-  "default",
-  "services-aliyun-drive",
-  "services-azfile",
-  "services-cacache",
-  "services-dashmap",
-  "services-dropbox",
-  # FIXME this service need protoc
-  # "services-etcd",
-  # FIXME this requires a preinstalled fdb library
-  # "services-foundationdb",
-  # "services-ftp",
-  "services-gdrive",
-  # FIXME how to support HDFS services in bindings?
-  # "services-hdfs",
-  # "services-hdfs-native",
-  "services-huggingface",
-  "services-ipfs",
-  "services-memcached",
-  "services-mini-moka",
-  "services-moka",
-  "services-onedrive",
-  "services-persy",
-  "services-postgresql",
-  "services-mysql",
-  "services-redb",
-  "services-redis",
-  # FIXME how to support rocksdb services in bindings?
-  # "services-rocksdb",
-  "services-sled",
-  "services-swift",
-  # FIXME this service need protoc
-  # "services-tikv",
-  "services-vercel-artifacts",
-  "services-mongodb",
-  "services-gridfs",
-  "services-sqlite",
-  "services-alluxio",
-  "services-b2",
-  "services-seafile",
-  "services-upyun",
-  "services-koofr",
-  "services-yandex-disk",
+  'default',
+  'services-aliyun-drive',

Review Comment:
   sorted and cleaned this area up. moved comments in 1 place below.
   
   re enabled the listed services



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org