You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/09 03:04:30 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7796: [TOPI, Relay] A new NMS op variant for ONNX NMS / TF Combined NMS

masahi edited a comment on pull request #7796:
URL: https://github.com/apache/tvm/pull/7796#issuecomment-816367364


   Thanks @trevor-m 
   
   1. Yes, we should be able to support such variant easily. The only place we touch box coords is here (`i` is the batch or row index, j and k are the index of sorted scores) https://github.com/apache/tvm/blob/6d314deb49898967361f62c194c9ea3685961dfd/python/tvm/topi/vision/nms_util.py#L132-L141 we can do arbitrary indirect indexing into boxes
   
   2. Yes, the new NMS will return indices, and it would be the job of frontend importer to do the gather. We can discuss what format of output would be most convenient for TF, and add `ret_type` attribute to specify which of ONNX or TF "mode" we return indices in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org