You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/17 07:06:21 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35487: [SPARK-38182][SQL] Fix NoSuchElementException if pushed filter does not contain any references

dongjoon-hyun commented on a change in pull request #35487:
URL: https://github.com/apache/spark/pull/35487#discussion_r808730457



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4281,6 +4281,18 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
         Row(2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22) :: Nil)
     }
   }
+
+  test("SPARK-38182: Fix NoSuchElementException if pushed filter does not contain any " +

Review comment:
       And, if you don't mind, could you add a minimal test coverage at `FileIndexSuite.scala` instead of `SQLQuerySuite`, @ulysses-you ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org