You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/16 10:28:37 UTC

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1100: Added an AWS2 SNS extension

ppalaga commented on a change in pull request #1100: Added an AWS2 SNS extension
URL: https://github.com/apache/camel-quarkus/pull/1100#discussion_r409450638
 
 

 ##########
 File path: integration-tests/aws2/src/main/resources/application.properties
 ##########
 @@ -20,15 +20,8 @@
 camel.context.name = quarkus-camel-example
 
 #
-# Camel :: AWS SQS
+# Camel :: AWS SNS
 #
-camel.component.aws2-sqs.access-key={{env:AWS_ACCESS_KEY}}
-camel.component.aws2-sqs.secret-key={{env:AWS_SECRET_KEY}}
-camel.component.aws2-sqs.region={{env:AWS_REGION}}
-
-#
-# Camel :: AWS S3
-#
-camel.component.aws2-s3.access-key={{env:AWS_ACCESS_KEY}}
-camel.component.aws2-s3.secret-key={{env:AWS_SECRET_KEY}}
-camel.component.aws2-s3.region={{env:AWS_REGION}}
\ No newline at end of file
+camel.component.aws2-*.access-key={{env:AWS_ACCESS_KEY}}
 
 Review comment:
   How is this asterisk key matched? The S3 extension checks both `camel.component.aws2-s3` and `camel.component.aws2-*` and uses whichever of the two is set?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services