You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/30 17:22:11 UTC
[GitHub] [druid] drcrallen commented on issue #9111: Add HashJoinSegment,
a virtual segment for joins.
drcrallen commented on issue #9111: Add HashJoinSegment, a virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#issuecomment-569739754
This is super cool thank you for putting this together. I would love to see a `README.md` (or similar) going over the high level mechanics of the join to help understand its limitations. I see a few comments scattered among classes but don't quite see the high level data flow. Is it all captured in https://github.com/apache/druid/issues/8728 , or are there more nuances in this PR since it is a foundation PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org