You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 06:33:38 UTC
[GitHub] [spark] panbingkun commented on a diff in pull request #38274: [SPARK-40810][SQL] Use SparkIllegalArgumentException instead of IllegalArgumentException in CreateDatabaseCommand & AlterDatabaseSetLocationCommand
panbingkun commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r996657816
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -68,10 +69,10 @@ trait CreateNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
- val e = intercept[IllegalArgumentException] {
+ val e = intercept[SparkIllegalArgumentException] {
sql(s"CREATE NAMESPACE $ns LOCATION ''")
}
- assert(e.getMessage.contains("Can not create a Path from an empty string"))
+ assert(e.getMessage.contains("Unsupported empty location"))
Review Comment:
ok, let me do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org