You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/09 01:33:49 UTC
Review Request 36338: Don't reject update requests scoped to
already-updated instances.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36338/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1332
https://issues.apache.org/jira/browse/AURORA-1332
Repository: aurora
Description
-------
Don't reject update requests scoped to already-updated instances.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12a1732a9fafde3d4180fde095ca57f35373771b
src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bd3196318b4fbd9f5fe5deb8294b5007f1ba93f0
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a5ca21bf1e53cce1573d4512d4048d1a37ed50de
src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java d0deada3dc5335b2b6c2794256e8429ef9a4646c
Diff: https://reviews.apache.org/r/36338/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 36338: Don't reject update requests scoped to
already-updated instances.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36338/#review91147
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On July 8, 2015, 4:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36338/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 4:33 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1332
> https://issues.apache.org/jira/browse/AURORA-1332
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't reject update requests scoped to already-updated instances.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12a1732a9fafde3d4180fde095ca57f35373771b
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bd3196318b4fbd9f5fe5deb8294b5007f1ba93f0
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a5ca21bf1e53cce1573d4512d4048d1a37ed50de
> src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java d0deada3dc5335b2b6c2794256e8429ef9a4646c
>
> Diff: https://reviews.apache.org/r/36338/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36338: Don't reject update requests scoped to
already-updated instances.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36338/#review91146
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On July 8, 2015, 11:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36338/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:33 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1332
> https://issues.apache.org/jira/browse/AURORA-1332
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't reject update requests scoped to already-updated instances.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12a1732a9fafde3d4180fde095ca57f35373771b
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bd3196318b4fbd9f5fe5deb8294b5007f1ba93f0
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a5ca21bf1e53cce1573d4512d4048d1a37ed50de
> src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java d0deada3dc5335b2b6c2794256e8429ef9a4646c
>
> Diff: https://reviews.apache.org/r/36338/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36338: Don't reject update requests scoped to
already-updated instances.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36338/#review91025
-----------------------------------------------------------
Ship it!
Master (8efcd06) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 8, 2015, 11:33 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36338/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:33 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1332
> https://issues.apache.org/jira/browse/AURORA-1332
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Don't reject update requests scoped to already-updated instances.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12a1732a9fafde3d4180fde095ca57f35373771b
> src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bd3196318b4fbd9f5fe5deb8294b5007f1ba93f0
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a5ca21bf1e53cce1573d4512d4048d1a37ed50de
> src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java d0deada3dc5335b2b6c2794256e8429ef9a4646c
>
> Diff: https://reviews.apache.org/r/36338/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>