You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by ws...@apache.org on 2005/11/24 05:17:54 UTC

svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Author: wsmoak
Date: Wed Nov 23 20:17:46 2005
New Revision: 348644

URL: http://svn.apache.org/viewcvs?rev=348644&view=rev
Log:
Minor changes to mailreader app: use inputSecret for passwords, get main menu title from bundle, and fix index title.

Modified:
    struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties   (contents, props changed)
    struts/shale/trunk/mailreader/src/web/mainMenu.jsp   (contents, props changed)
    struts/shale/trunk/mailreader/src/web/registration.jsp   (contents, props changed)

Modified: struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties?rev=348644&r1=348643&r2=348644&view=diff
==============================================================================
--- struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties (original)
+++ struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties Wed Nov 23 20:17:46 2005
@@ -1,5 +1,5 @@
 # ==============================================================================
-# Copyright 2002,2004 The Apache Software Foundation.
+# Copyright 2002-2005 The Apache Software Foundation.
 # 
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -57,7 +57,7 @@
 index.heading=MailReader Demonstration Application Options
 index.logon=Log on to the MailReader Demonstration Application
 index.registration=Register with the MailReader Demonstration Application
-index.title=MailReader Demonstration Application (Struts 1.1-dev)
+index.title=MailReader Demonstration Application
 index.tour=A Walking Tour of the Example Application
 linkSubscription.io=I/O Error: {0}
 linkSubscription.noSubscription=No subscription under attribute {0}

Propchange: struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
------------------------------------------------------------------------------
    svn:keywords = Date Author Id Revision HeadURL

Modified: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/web/mainMenu.jsp?rev=348644&r1=348643&r2=348644&view=diff
==============================================================================
--- struts/shale/trunk/mailreader/src/web/mainMenu.jsp (original)
+++ struts/shale/trunk/mailreader/src/web/mainMenu.jsp Wed Nov 23 20:17:46 2005
@@ -4,7 +4,7 @@
 
 <!--
 
- Copyright 2002,2004 The Apache Software Foundation.
+ Copyright 2002-2005 The Apache Software Foundation.
  
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@
 <html>
 <head>
   <title>
-    <h:outputText   value="mainMenu.title"/>
+    <h:outputText   value="#{messages['mainMenu.title']}"/>
   </title>
 </head>
 <body>

Propchange: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
------------------------------------------------------------------------------
    svn:keywords = Date Author Id Revision HeadURL

Modified: struts/shale/trunk/mailreader/src/web/registration.jsp
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/web/registration.jsp?rev=348644&r1=348643&r2=348644&view=diff
==============================================================================
--- struts/shale/trunk/mailreader/src/web/registration.jsp (original)
+++ struts/shale/trunk/mailreader/src/web/registration.jsp Wed Nov 23 20:17:46 2005
@@ -4,7 +4,7 @@
 
 <!--
 
- Copyright 2002,2004 The Apache Software Foundation.
+ Copyright 2002-2005 The Apache Software Foundation.
  
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
@@ -83,7 +83,7 @@
       <h:outputText value="#{messages['prompt.password']}"/>
     </h:outputLabel>
 
-    <h:inputText       id="password"
+    <h:inputSecret     id="password"
                      size="16"
                  required="#{state.mode == 'CREATE'}"
                     value="#{registration.password}"/>
@@ -96,7 +96,7 @@
       <h:outputText value="#{messages['prompt.password2']}"/>
     </h:outputLabel>
 
-    <h:inputText       id="password2"
+    <h:inputSecret     id="password2"
                      size="16"
                  required="#{state.mode == 'CREATE'}"
                     value="#{registration.password2}"/>

Propchange: struts/shale/trunk/mailreader/src/web/registration.jsp
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: struts/shale/trunk/mailreader/src/web/registration.jsp
------------------------------------------------------------------------------
    svn:keywords = Date Author Id Revision HeadURL



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Posted by Wendy Smoak <ws...@gmail.com>.
On 11/23/05, James Mitchell <jm...@apache.org> wrote:

> Steps to recreate:
>  Login
>  Edit Registration
>  Add Subscription    <-- looks good
>  Edit Subscription   <-- screen is wrong
>  Delete Subscription <-- screen is wrong

I click Edit, I get the expected edit screen, I click Save...
Back at the list of subscriptions, I click Delete, get a confirmation
screen, Click Confirm...
Back at the list of subscriptions (without the deleted one).

I think I found the note you're referring to-- it just redisplays the
list of subscriptions?

So... Tomcat 5.0.30, JDK 1.4.2_09, WinXP Pro, and this is the Maven
build-- I tried the build.xml file, but it's doing things like looking
for BeanUtils under ${jsf.home} and anything I changed only made it
worse.

I do get a NPE at line 391 of Registration after several minutes of
inactivity-- I assume the session has timed out and 'user' is null.

--
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Posted by James Mitchell <jm...@apache.org>.
Err...once more...

Steps to recreate:
 Login
 Edit Registration
 Add Subscription    <-- looks good
 Edit Subscription   <-- screen is wrong
 Delete Subscription <-- screen is wrong


--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
http://www.edgetechservices.net/
678.910.8017
AIM:   jmitchtx
MSN:   jmitchell@apache.org
Skype: jmitchtx

----- Original Message ----- 
From: "James Mitchell" <jm...@apache.org>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Thursday, November 24, 2005 12:05 AM
Subject: Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: 
java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
web/mainMenu.jsp web/registration.jsp


> Are you sure?
>
> Steps to recreate:
> Login
> Edit Registration
> Add Registration    <-- looks good
> Edit Subscription   <-- screen is wrong
> Delete Subscription <-- screen is wrong
>
>
> --
> James Mitchell
> Software Engineer / Open Source Evangelist
> Consulting / Mentoring / Freelance
> EdgeTech, Inc.
> http://www.edgetechservices.net/
> 678.910.8017
> AIM:   jmitchtx
> MSN:   jmitchell@apache.org
> Skype: jmitchtx
>
> ----- Original Message ----- 
> From: "Wendy Smoak" <ws...@gmail.com>
> To: "Struts Developers List" <de...@struts.apache.org>
> Sent: Wednesday, November 23, 2005 11:40 PM
> Subject: Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: 
> java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
> web/mainMenu.jsp web/registration.jsp
>
>
> On 11/23/05, James Mitchell <jm...@apache.org> wrote:
>> When you run the mailreader app, do you see the same issue with edit
>> subscription as I do (mentioned on a previous commit)?
>
> No problems here... maybe the move to MyFaces 1.1.1 fixed it?
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Posted by James Mitchell <jm...@apache.org>.
Are you sure?

Steps to recreate:
 Login
 Edit Registration
 Add Registration    <-- looks good
 Edit Subscription   <-- screen is wrong
 Delete Subscription <-- screen is wrong


--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
http://www.edgetechservices.net/
678.910.8017
AIM:   jmitchtx
MSN:   jmitchell@apache.org
Skype: jmitchtx

----- Original Message ----- 
From: "Wendy Smoak" <ws...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Wednesday, November 23, 2005 11:40 PM
Subject: Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: 
java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
web/mainMenu.jsp web/registration.jsp


On 11/23/05, James Mitchell <jm...@apache.org> wrote:
> When you run the mailreader app, do you see the same issue with edit
> subscription as I do (mentioned on a previous commit)?

No problems here... maybe the move to MyFaces 1.1.1 fixed it?

--
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Posted by Wendy Smoak <ws...@gmail.com>.
On 11/23/05, James Mitchell <jm...@apache.org> wrote:
> When you run the mailreader app, do you see the same issue with edit
> subscription as I do (mentioned on a previous commit)?

No problems here... maybe the move to MyFaces 1.1.1 fixed it?

--
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: java/org/apache/shale/examples/mailreader/ApplicationResources.properties web/mainMenu.jsp web/registration.jsp

Posted by James Mitchell <jm...@apache.org>.
When you run the mailreader app, do you see the same issue with edit 
subscription as I do (mentioned on a previous commit)?



--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
http://www.edgetechservices.net/
678.910.8017
AIM:   jmitchtx
MSN:   jmitchell@apache.org
Skype: jmitchtx

----- Original Message ----- 
From: <ws...@apache.org>
To: <co...@struts.apache.org>
Sent: Wednesday, November 23, 2005 11:17 PM
Subject: svn commit: r348644 - in /struts/shale/trunk/mailreader/src: 
java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
web/mainMenu.jsp web/registration.jsp


> Author: wsmoak
> Date: Wed Nov 23 20:17:46 2005
> New Revision: 348644
>
> URL: http://svn.apache.org/viewcvs?rev=348644&view=rev
> Log:
> Minor changes to mailreader app: use inputSecret for passwords, get main 
> menu title from bundle, and fix index title.
>
> Modified:
> 
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
> (contents, props changed)
>    struts/shale/trunk/mailreader/src/web/mainMenu.jsp   (contents, props 
> changed)
>    struts/shale/trunk/mailreader/src/web/registration.jsp   (contents, 
> props changed)
>
> Modified: 
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
> URL: 
> http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties?rev=348644&r1=348643&r2=348644&view=diff
> ==============================================================================
> ---  
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
> (original)
> +++ 
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties 
> Wed Nov 23 20:17:46 2005
> @@ -1,5 +1,5 @@
> # 
> ==============================================================================
> -# Copyright 2002,2004 The Apache Software Foundation.
> +# Copyright 2002-2005 The Apache Software Foundation.
> #
> # Licensed under the Apache License, Version 2.0 (the "License");
> # you may not use this file except in compliance with the License.
> @@ -57,7 +57,7 @@
> index.heading=MailReader Demonstration Application Options
> index.logon=Log on to the MailReader Demonstration Application
> index.registration=Register with the MailReader Demonstration Application
> -index.title=MailReader Demonstration Application (Struts 1.1-dev)
> +index.title=MailReader Demonstration Application
> index.tour=A Walking Tour of the Example Application
> linkSubscription.io=I/O Error: {0}
> linkSubscription.noSubscription=No subscription under attribute {0}
>
> Propchange: 
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
> ------------------------------------------------------------------------------
>    svn:eol-style = native
>
> Propchange: 
> struts/shale/trunk/mailreader/src/java/org/apache/shale/examples/mailreader/ApplicationResources.properties
> ------------------------------------------------------------------------------
>    svn:keywords = Date Author Id Revision HeadURL
>
> Modified: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
> URL: 
> http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/web/mainMenu.jsp?rev=348644&r1=348643&r2=348644&view=diff
> ==============================================================================
> --- struts/shale/trunk/mailreader/src/web/mainMenu.jsp (original)
> +++ struts/shale/trunk/mailreader/src/web/mainMenu.jsp Wed Nov 23 20:17:46 
> 2005
> @@ -4,7 +4,7 @@
>
> <!--
>
> - Copyright 2002,2004 The Apache Software Foundation.
> + Copyright 2002-2005 The Apache Software Foundation.
>
>  Licensed under the Apache License, Version 2.0 (the "License");
>  you may not use this file except in compliance with the License.
> @@ -27,7 +27,7 @@
> <html>
> <head>
>   <title>
> -    <h:outputText   value="mainMenu.title"/>
> +    <h:outputText   value="#{messages['mainMenu.title']}"/>
>   </title>
> </head>
> <body>
>
> Propchange: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
> ------------------------------------------------------------------------------
>    svn:eol-style = native
>
> Propchange: struts/shale/trunk/mailreader/src/web/mainMenu.jsp
> ------------------------------------------------------------------------------
>    svn:keywords = Date Author Id Revision HeadURL
>
> Modified: struts/shale/trunk/mailreader/src/web/registration.jsp
> URL: 
> http://svn.apache.org/viewcvs/struts/shale/trunk/mailreader/src/web/registration.jsp?rev=348644&r1=348643&r2=348644&view=diff
> ==============================================================================
> --- struts/shale/trunk/mailreader/src/web/registration.jsp (original)
> +++ struts/shale/trunk/mailreader/src/web/registration.jsp Wed Nov 23 
> 20:17:46 2005
> @@ -4,7 +4,7 @@
>
> <!--
>
> - Copyright 2002,2004 The Apache Software Foundation.
> + Copyright 2002-2005 The Apache Software Foundation.
>
>  Licensed under the Apache License, Version 2.0 (the "License");
>  you may not use this file except in compliance with the License.
> @@ -83,7 +83,7 @@
>       <h:outputText value="#{messages['prompt.password']}"/>
>     </h:outputLabel>
>
> -    <h:inputText       id="password"
> +    <h:inputSecret     id="password"
>                      size="16"
>                  required="#{state.mode == 'CREATE'}"
>                     value="#{registration.password}"/>
> @@ -96,7 +96,7 @@
>       <h:outputText value="#{messages['prompt.password2']}"/>
>     </h:outputLabel>
>
> -    <h:inputText       id="password2"
> +    <h:inputSecret     id="password2"
>                      size="16"
>                  required="#{state.mode == 'CREATE'}"
>                     value="#{registration.password2}"/>
>
> Propchange: struts/shale/trunk/mailreader/src/web/registration.jsp
> ------------------------------------------------------------------------------
>    svn:eol-style = native
>
> Propchange: struts/shale/trunk/mailreader/src/web/registration.jsp
> ------------------------------------------------------------------------------
>    svn:keywords = Date Author Id Revision HeadURL
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org