You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "mynameborat (via GitHub)" <gi...@apache.org> on 2023/06/22 21:52:53 UTC

[GitHub] [samza] mynameborat commented on pull request #1674: Close SystemConsumer properly

mynameborat commented on PR #1674:
URL: https://github.com/apache/samza/pull/1674#issuecomment-1603361792

   I don't think there is any problem with the existing code. For active containers, the expected behavior is to keep the `KafkaCheckpointManager` started until the entire container is shutdown which would trigger stop.
   
   On the other hand, for standby containers, there is need to only read checkpoint once and hence closes right after.
   
   I'd trace it back to see if there is any violation in how this flag is set and assumptions that this flag is built on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org