You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Eks Dev (JIRA)" <ji...@apache.org> on 2009/04/26 17:07:30 UTC

[jira] Created: (LUCENE-1615) deprecated method used in fieldsReader / setOmitTf()

deprecated method used in fieldsReader / setOmitTf()
----------------------------------------------------

                 Key: LUCENE-1615
                 URL: https://issues.apache.org/jira/browse/LUCENE-1615
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
            Reporter: Eks Dev
            Priority: Trivial


setOmitTf(boolean) is deprecated and should not be used by core classes. One place where it appears is FieldsReader , this patch fixes it. It was necessary to change Fieldable to AbstractField at two places, only local variables.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1615) deprecated method used in fieldsReader / setOmitTf()

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702896#action_12702896 ] 

Uwe Schindler commented on LUCENE-1615:
---------------------------------------

We know this problem, your fix seems ok (LUCENE-1561).
We did not want to change the Fieldable interface again, so we left omitTf in the interface but deprecated the methods in AbstractField & Co. In future, the Fieldable interface should be completely removed for 3.0 and this is a first step towards it! All references to Fieldable should be replaced by AbstractField or a better alternative that also has the type in it (see LUCENE-1597)

> deprecated method used in fieldsReader / setOmitTf()
> ----------------------------------------------------
>
>                 Key: LUCENE-1615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1615
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Eks Dev
>            Priority: Trivial
>         Attachments: LUCENE-1615.patch
>
>
> setOmitTf(boolean) is deprecated and should not be used by core classes. One place where it appears is FieldsReader , this patch fixes it. It was necessary to change Fieldable to AbstractField at two places, only local variables.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1615) deprecated method used in fieldsReader / setOmitTf()

Posted by "Eks Dev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702901#action_12702901 ] 

Eks Dev commented on LUCENE-1615:
---------------------------------

sure, replacing Fieldable is good,  just noticed quick win when cleaning-up deprecations from our code base... one step in a time 

> deprecated method used in fieldsReader / setOmitTf()
> ----------------------------------------------------
>
>                 Key: LUCENE-1615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1615
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Eks Dev
>            Priority: Trivial
>         Attachments: LUCENE-1615.patch
>
>
> setOmitTf(boolean) is deprecated and should not be used by core classes. One place where it appears is FieldsReader , this patch fixes it. It was necessary to change Fieldable to AbstractField at two places, only local variables.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1615) deprecated method used in fieldsReader / setOmitTf()

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1615.
----------------------------------------

    Resolution: Fixed

OK I just committed this -- thanks Eks!

> deprecated method used in fieldsReader / setOmitTf()
> ----------------------------------------------------
>
>                 Key: LUCENE-1615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1615
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Eks Dev
>            Priority: Trivial
>         Attachments: LUCENE-1615.patch
>
>
> setOmitTf(boolean) is deprecated and should not be used by core classes. One place where it appears is FieldsReader , this patch fixes it. It was necessary to change Fieldable to AbstractField at two places, only local variables.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1615) deprecated method used in fieldsReader / setOmitTf()

Posted by "Eks Dev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eks Dev updated LUCENE-1615:
----------------------------

    Attachment: LUCENE-1615.patch

> deprecated method used in fieldsReader / setOmitTf()
> ----------------------------------------------------
>
>                 Key: LUCENE-1615
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1615
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Eks Dev
>            Priority: Trivial
>         Attachments: LUCENE-1615.patch
>
>
> setOmitTf(boolean) is deprecated and should not be used by core classes. One place where it appears is FieldsReader , this patch fixes it. It was necessary to change Fieldable to AbstractField at two places, only local variables.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org