You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prashantwason (via GitHub)" <gi...@apache.org> on 2023/05/16 07:45:05 UTC
[GitHub] [hudi] prashantwason opened a new pull request, #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
prashantwason opened a new pull request, #8724:
URL: https://github.com/apache/hudi/pull/8724
[HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
### Change Logs
1. Added a class HUDIVersion which can be used to get HUDI version
2. Added HUDI version and other engine specific information to HoodieCOmmitMetadata as extraMetadata
3. Added HUDI version to the file comment for hoodie.properties
### Impact
More debugging information available
### Risk level (write none, low medium or high below)
None
### Documentation Update
None
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1640057881
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660",
"triggerID" : "1640030163",
"triggerType" : "MANUAL"
}, {
"hash" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18661",
"triggerID" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660)
* e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18661)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1577402949
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1601742968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1550960264
will review this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1578055193
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612)
* dd2b1175e68145938699cf8f4d1a670d79d2c01a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1640337419
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660",
"triggerID" : "1640030163",
"triggerType" : "MANUAL"
}, {
"hash" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18661",
"triggerID" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18661)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1549178433
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92acc9f0258fda8f49ccf5937ae6b280a808e1fe UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6220] Add HUDI code version to commit files and hoodie.properties. [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1747341965
@prashantwason : Can you fix the conflictx and test so that we can land this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1601621237
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-6220] Add HUDI code version to commit files and hoodie.properties. [hudi]
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason closed pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
URL: https://github.com/apache/hudi/pull/8724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1218842004
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -112,7 +112,7 @@ private void setHostAddr(String embeddedTimelineServiceHostAddr) {
this.hostAddr = embeddedTimelineServiceHostAddr;
} else {
LOG.warn("Unable to find driver bind address from spark config");
- this.hostAddr = NetworkUtils.getHostname();
+ this.hostAddr = NetworkUtils.getHostAddr();
Review Comment:
Is the change related with the patch? Are there any host info persisted into the `properties` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1578065824
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612)
* dd2b1175e68145938699cf8f4d1a670d79d2c01a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1596807985
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd2b1175e68145938699cf8f4d1a670d79d2c01a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625)
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1560526670
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92acc9f0258fda8f49ccf5937ae6b280a808e1fe Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115)
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1638975709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036)
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1640048004
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660",
"triggerID" : "1640030163",
"triggerType" : "MANUAL"
}, {
"hash" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660)
* e55775240fa2552195fcb7dd6dc26e2b2ce1eb9e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1569145580
Hi @prashantwason could you check the build failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1640030163
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1549243056
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92acc9f0258fda8f49ccf5937ae6b280a808e1fe Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203470106
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -310,12 +312,16 @@ private static Properties getOrderedPropertiesWithTableChecksum(Properties props
*/
private static String storeProperties(Properties props, FSDataOutputStream outputStream) throws IOException {
final String checksum;
- if (isValidChecksum(props)) {
+ final boolean isValidChecksum = isValidChecksum(props);
+ final String comment = String.format("Date=%s, host=%s, #properties=%d, hudi_version=%s",
+ Instant.now(), NetworkUtils.getHostname(), isValidChecksum ? props.size() : props.size() + 1, HoodieVersion.get());
Review Comment:
NetworkUtils.getHostname() does not return hostname - it returns IP address. So this is a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1560519482
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92acc9f0258fda8f49ccf5937ae6b280a808e1fe Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115)
* 92d5c0349641d888a691d02d13678f0f552f1e8f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1638982366
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036)
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1201317230
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -310,12 +312,16 @@ private static Properties getOrderedPropertiesWithTableChecksum(Properties props
*/
private static String storeProperties(Properties props, FSDataOutputStream outputStream) throws IOException {
final String checksum;
- if (isValidChecksum(props)) {
+ final boolean isValidChecksum = isValidChecksum(props);
+ final String comment = String.format("Date=%s, host=%s, #properties=%d, hudi_version=%s",
+ Instant.now(), NetworkUtils.getHostname(), isValidChecksum ? props.size() : props.size() + 1, HoodieVersion.get());
Review Comment:
if you modified NetworkUtils.getHostname() just for this purpose, lets keep the existing method and add a new one.
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/client/common/HoodieJavaEngineContext.java:
##########
@@ -161,4 +162,11 @@ public List<Integer> getCachedDataIds(HoodieDataCacheKey cacheKey) {
public List<Integer> removeCachedDataIds(HoodieDataCacheKey cacheKey) {
return Collections.emptyList();
}
+
+ @Override
+ public Map<String, String> getInfo() {
+ final Map<String, String> info = new HashMap<>();
+ System.getProperties().stringPropertyNames().forEach(property -> info.put(property, System.getProperty(property)));
Review Comment:
yes. we should be judicious here
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -214,4 +214,17 @@ public List<Integer> removeCachedDataIds(HoodieDataCacheKey cacheKey) {
return removed == null ? Collections.emptyList() : removed;
}
}
+
+ @Override
+ public Map<String, String> getInfo() {
+ Map<String, String> info = new HashMap<>();
+ info.put("spark.user", javaSparkContext.sparkUser());
+ info.put("spark.master", javaSparkContext.master());
+ info.put("spark.application", javaSparkContext.appName());
+ info.put("spark.version", javaSparkContext.version());
+ info.put("spark.defaultParallelism", String.valueOf(javaSparkContext.defaultParallelism()));
+ info.put("spark.defaultMinPartitions", String.valueOf(javaSparkContext.defaultMinPartitions()));
+ info.put("spark.executor.instances", String.valueOf(javaSparkContext.getConf().get("spark.executor.instances")));
+ return info;
Review Comment:
should we also let users configure any hoodie write configs to be added to the extra metadata. since we don't serialize them anywhere, sometimes might come in handy during investigations. by default we don't need to add any hoodie write configs. but if user configures them, we can add them as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203468779
##########
hudi-common/src/main/java/org/apache/hudi/HoodieVersion.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi;
+
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.common.util.ValidationUtils;
+
+/**
+ * Exposes the <a href="https://semver.org/">semantic versioning</a> of HUDI code.
+ *
+ * HUDI versions are configured through maven and are formatted as <major>.<minor>.<patch>. Example: 0.12.2 or 0.12.3-snapshot
+ */
+public final class HoodieVersion {
+ /**
+ * Returns the complete version of HUDI code
+ * Example: 0.12.2 or 0.12.3-snapshot
+ */
+ public static String get() {
+ // This reads the property "Implementation-Version" of the generated META-INF/MANIFEST.MF (that is set to the pom.xml's version) in the archive
+ // from where this class is loaded. Due to this, this is available only in release jars and not for unit-tests.
+ String versionStr = HoodieVersion.class.getPackage().getImplementationVersion();
+ if (StringUtils.isNullOrEmpty(versionStr)) {
+ // Possible in unit tests
+ versionStr = "0.0.0";
+ }
+ return versionStr;
+ }
+
+ /**
+ * Returns the major version of HUDI code
+ * Example: 0 for 0.12.2
+ */
+ public static String major() {
+ return getVersionParts()[0];
+ }
+
+ /**
+ * Returns the minor version of HUDI code
+ * Example: 12 for 0.12.2
+ */
+ public static String minor() {
+ return getVersionParts()[1];
+ }
+
+ /**
+ * Returns the patch version of HUDI code
+ * Example: 2 for 0.12.2, 3-SNAPSHOT for 0.12.3-SNAPSHOT
+ */
+ public static String patch() {
+ return getVersionParts()[2];
+ }
+
+ private static String[] getVersionParts() {
+ String[] parts = get().split("\\.");
+ ValidationUtils.checkArgument(parts.length == 3, "HUDI version is not in the format major.minor.patch: " + get());
+ return parts;
+ }
+
+ public static void main(String[] args) {
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1561162701
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1197160781
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -112,7 +112,7 @@ private void setHostAddr(String embeddedTimelineServiceHostAddr) {
this.hostAddr = embeddedTimelineServiceHostAddr;
} else {
LOG.warn("Unable to find driver bind address from spark config");
- this.hostAddr = NetworkUtils.getHostname();
+ this.hostAddr = NetworkUtils.getHostAddr();
Review Comment:
What is the rational for this change ?
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/client/common/HoodieJavaEngineContext.java:
##########
@@ -161,4 +162,11 @@ public List<Integer> getCachedDataIds(HoodieDataCacheKey cacheKey) {
public List<Integer> removeCachedDataIds(HoodieDataCacheKey cacheKey) {
return Collections.emptyList();
}
+
+ @Override
+ public Map<String, String> getInfo() {
+ final Map<String, String> info = new HashMap<>();
+ System.getProperties().stringPropertyNames().forEach(property -> info.put(property, System.getProperty(property)));
Review Comment:
Instead of blindly copying all properties, we should do this selectively, as there may be sensitive information here.
##########
hudi-common/src/main/java/org/apache/hudi/HoodieVersion.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi;
+
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.common.util.ValidationUtils;
+
+/**
+ * Exposes the <a href="https://semver.org/">semantic versioning</a> of HUDI code.
+ *
+ * HUDI versions are configured through maven and are formatted as <major>.<minor>.<patch>. Example: 0.12.2 or 0.12.3-snapshot
+ */
+public final class HoodieVersion {
+ /**
+ * Returns the complete version of HUDI code
+ * Example: 0.12.2 or 0.12.3-snapshot
+ */
+ public static String get() {
+ // This reads the property "Implementation-Version" of the generated META-INF/MANIFEST.MF (that is set to the pom.xml's version) in the archive
+ // from where this class is loaded. Due to this, this is available only in release jars and not for unit-tests.
+ String versionStr = HoodieVersion.class.getPackage().getImplementationVersion();
+ if (StringUtils.isNullOrEmpty(versionStr)) {
+ // Possible in unit tests
+ versionStr = "0.0.0";
+ }
+ return versionStr;
+ }
+
+ /**
+ * Returns the major version of HUDI code
+ * Example: 0 for 0.12.2
+ */
+ public static String major() {
+ return getVersionParts()[0];
+ }
+
+ /**
+ * Returns the minor version of HUDI code
+ * Example: 12 for 0.12.2
+ */
+ public static String minor() {
+ return getVersionParts()[1];
+ }
+
+ /**
+ * Returns the patch version of HUDI code
+ * Example: 2 for 0.12.2, 3-SNAPSHOT for 0.12.3-SNAPSHOT
+ */
+ public static String patch() {
+ return getVersionParts()[2];
+ }
+
+ private static String[] getVersionParts() {
+ String[] parts = get().split("\\.");
+ ValidationUtils.checkArgument(parts.length == 3, "HUDI version is not in the format major.minor.patch: " + get());
+ return parts;
+ }
+
+ public static void main(String[] args) {
Review Comment:
Can you remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203468378
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/client/common/HoodieJavaEngineContext.java:
##########
@@ -161,4 +162,11 @@ public List<Integer> getCachedDataIds(HoodieDataCacheKey cacheKey) {
public List<Integer> removeCachedDataIds(HoodieDataCacheKey cacheKey) {
return Collections.emptyList();
}
+
+ @Override
+ public Map<String, String> getInfo() {
+ final Map<String, String> info = new HashMap<>();
+ System.getProperties().stringPropertyNames().forEach(property -> info.put(property, System.getProperty(property)));
Review Comment:
These files are within the dataset itself. The dataset would contain sensitive information too. So I dont see the issue.
Anyways, I will filter them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1549500411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92acc9f0258fda8f49ccf5937ae6b280a808e1fe Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1597156189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1601678102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1578164335
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd2b1175e68145938699cf8f4d1a670d79d2c01a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1577413873
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 92d5c0349641d888a691d02d13678f0f552f1e8f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1577385948
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1640037160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660",
"triggerID" : "1640030163",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18660)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203473413
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -214,4 +214,17 @@ public List<Integer> removeCachedDataIds(HoodieDataCacheKey cacheKey) {
return removed == null ? Collections.emptyList() : removed;
}
}
+
+ @Override
+ public Map<String, String> getInfo() {
+ Map<String, String> info = new HashMap<>();
+ info.put("spark.user", javaSparkContext.sparkUser());
+ info.put("spark.master", javaSparkContext.master());
+ info.put("spark.application", javaSparkContext.appName());
+ info.put("spark.version", javaSparkContext.version());
+ info.put("spark.defaultParallelism", String.valueOf(javaSparkContext.defaultParallelism()));
+ info.put("spark.defaultMinPartitions", String.valueOf(javaSparkContext.defaultMinPartitions()));
+ info.put("spark.executor.instances", String.valueOf(javaSparkContext.getConf().get("spark.executor.instances")));
+ return info;
Review Comment:
Simply easier to add the entire hoodie config (without schema).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203459409
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -112,7 +112,7 @@ private void setHostAddr(String embeddedTimelineServiceHostAddr) {
this.hostAddr = embeddedTimelineServiceHostAddr;
} else {
LOG.warn("Unable to find driver bind address from spark config");
- this.hostAddr = NetworkUtils.getHostname();
+ this.hostAddr = NetworkUtils.getHostAddr();
Review Comment:
Also, I added the getHostName function which returns the hostname
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] prashantwason commented on a diff in pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8724:
URL: https://github.com/apache/hudi/pull/8724#discussion_r1203459158
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -112,7 +112,7 @@ private void setHostAddr(String embeddedTimelineServiceHostAddr) {
this.hostAddr = embeddedTimelineServiceHostAddr;
} else {
LOG.warn("Unable to find driver bind address from spark config");
- this.hostAddr = NetworkUtils.getHostname();
+ this.hostAddr = NetworkUtils.getHostAddr();
Review Comment:
The NetworkUtils.getHostname function is returning the IP address. So renamed it to getHostAddr which is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1639032411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18036",
"triggerID" : "1601621237",
"triggerType" : "MANUAL"
}, {
"hash" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648",
"triggerID" : "8525623c524703c276a4f6bc3be1ede70fc2d2d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8525623c524703c276a4f6bc3be1ede70fc2d2d7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18648)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8724: [HUDI-6220] Add HUDI code version to commit files and hoodie.properties.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8724:
URL: https://github.com/apache/hudi/pull/8724#issuecomment-1596822371
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17115",
"triggerID" : "92acc9f0258fda8f49ccf5937ae6b280a808e1fe",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17329",
"triggerID" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"triggerType" : "PUSH"
}, {
"hash" : "92d5c0349641d888a691d02d13678f0f552f1e8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17612",
"triggerID" : "1577385948",
"triggerType" : "MANUAL"
}, {
"hash" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625",
"triggerID" : "dd2b1175e68145938699cf8f4d1a670d79d2c01a",
"triggerType" : "PUSH"
}, {
"hash" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972",
"triggerID" : "7b99dacd8ecdada77cb2e47fd59b6160576ba2e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd2b1175e68145938699cf8f4d1a670d79d2c01a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17625)
* 7b99dacd8ecdada77cb2e47fd59b6160576ba2e6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17972)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org