[GitHub] [iceberg] kbendick commented on a change in pull request #3938: API: Disallow Namespace with null byte character or null level in it

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3938:
URL: https://github.com/apache/iceberg/pull/3938#discussion_r800986771



##########
File path: api/src/test/java/org/apache/iceberg/catalog/TestNamespace.java
##########
@@ -44,4 +45,31 @@ public void testNamespace() {
       Assertions.assertThat(namespace.level(i)).isEqualTo(levels[i]);
     }
   }
+
+  @Test
+  public void testWithNullInLevel() {
+    AssertHelpers.assertThrows(
+        "An individual level of a namespace cannot be null",
+        IllegalArgumentException.class,

Review comment:
       Ahh good catch. Thank you! It was previously a different precondition check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org