You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/04/29 16:12:28 UTC

(datafusion) 01/01: chore: fix `iff` typos (#21904)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-21904-f0c53066f0f4977167b25c98296b9b4183f96524
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit 5fda21683ed73f89b06431fac94777d6b1540b02
Author: Oleks V <co...@users.noreply.github.com>
AuthorDate: Wed Apr 29 09:12:19 2026 -0700

    chore: fix `iff` typos (#21904)
    
    ## Which issue does this PR close?
    
    <!--
    We generally require a GitHub issue to be filed for all bug fixes and
    enhancements and this helps us generate change logs for our releases.
    You can link an issue to this PR using the GitHub syntax. For example
    `Closes #123` indicates that this PR will close issue #123.
    -->
    
    - Closes #.
    
    ## Rationale for this change
    
    <!--
    Why are you proposing this change? If this is already explained clearly
    in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand
    your changes and offer better suggestions for fixes.
    -->
    
    ## What changes are included in this PR?
    
    <!--
    There is no need to duplicate the description in the issue here but it
    is sometimes worth providing a summary of the individual changes in this
    PR.
    -->
    
    ## Are these changes tested?
    
    <!--
    We typically require tests for all PRs in order to:
    1. Prevent the code from being accidentally broken by subsequent changes
    2. Serve as another way to document the expected behavior of the code
    
    If tests are not included in your PR, please explain why (for example,
    are they covered by existing tests)?
    -->
    
    ## Are there any user-facing changes?
    
    <!--
    If there are user-facing changes then we may require documentation to be
    updated before approving the PR.
    -->
    
    <!--
    If there are any breaking changes to public APIs, please add the `api
    change` label.
    -->
    
    ---------
    
    Co-authored-by: Yongting You <20...@gmail.com>
---
 datafusion/datasource-parquet/src/row_filter.rs | 2 +-
 datafusion/functions/src/unicode/substrindex.rs | 2 +-
 datafusion/sql/src/relation/join.rs             | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/datafusion/datasource-parquet/src/row_filter.rs b/datafusion/datasource-parquet/src/row_filter.rs
index c5c3720558..6dfaa731ae 100644
--- a/datafusion/datasource-parquet/src/row_filter.rs
+++ b/datafusion/datasource-parquet/src/row_filter.rs
@@ -768,7 +768,7 @@ fn resolve_struct_field_leaves(
             // e.g., prefix=["s", "value"] matches leaf path ["s", "value"]
             // prefix=["s", "outer"] matches ["s", "outer", "inner"]
 
-            // a leaf matches iff its path starts with our prefix
+            // a leaf matches if its path starts with our prefix
             // for example: prefix=["s", "value"] matches leaf path ["s", "value"]
             //              prefix=["s", "outer"] matches ["s", "outer", "inner"]
             let leaf_matches_path = col_path.len() >= prefix.len()
diff --git a/datafusion/functions/src/unicode/substrindex.rs b/datafusion/functions/src/unicode/substrindex.rs
index d522a35842..3aeff1b476 100644
--- a/datafusion/functions/src/unicode/substrindex.rs
+++ b/datafusion/functions/src/unicode/substrindex.rs
@@ -272,7 +272,7 @@ where
     O: OffsetSizeTrait,
 {
     let num_rows = string_array.len();
-    // Output is null IFF any input is null.
+    // Output is null if and only if any input is null.
     let nulls = NullBuffer::union(
         NullBuffer::union(string_array.nulls(), delimiter_array.nulls()).as_ref(),
         count_array.nulls(),
diff --git a/datafusion/sql/src/relation/join.rs b/datafusion/sql/src/relation/join.rs
index 8e1a881730..3343890c6d 100644
--- a/datafusion/sql/src/relation/join.rs
+++ b/datafusion/sql/src/relation/join.rs
@@ -179,7 +179,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
     }
 }
 
-/// Return `true` iff the given [`TableFactor`] is lateral.
+/// Returns `true` if the given [`TableFactor`] is lateral.
 pub(crate) fn is_lateral(factor: &TableFactor) -> bool {
     match factor {
         TableFactor::Derived { lateral, .. } => *lateral,
@@ -189,7 +189,7 @@ pub(crate) fn is_lateral(factor: &TableFactor) -> bool {
     }
 }
 
-/// Return `true` iff the given [`Join`] is lateral.
+/// Returns `true` if the given [`Join`] is lateral.
 pub(crate) fn is_lateral_join(join: &Join) -> Result<bool> {
     let is_lateral_syntax = is_lateral(&join.relation);
     let is_apply_syntax = match join.join_operator {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org