[GitHub] [beam] TheNeuralBit commented on a change in pull request #15485: [BEAM-10655] Fix conversion of NanosInstant to BigQuery Timestamp

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15485:
URL: https://github.com/apache/beam/pull/15485#discussion_r709603791



##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtilsTest.java
##########
@@ -626,6 +666,14 @@ public void testToTableRow_enum() {
     assertThat(row, hasEntry("color", "GREEN"));
   }
 
+  @Test
+  public void testToTableRow_nanosInstant() {
+    TableRow row = toTableRow().apply(NANOS_INSTANT_ROW);
+
+    assertThat(row.size(), equalTo(1));
+    assertThat(row, hasEntry("nanos_instant", "2021-09-03T18:12:12.123456789Z"));

Review comment:
       Will this TableRow work when it hits BigQuery? or will it raise an error? I think we may need to either:
   - Reject this row in Beam, or
   - Truncate the timestamp proactively
   
   It would be best if the user could choose between these approaches with an option on `BigQueryIO.Write`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org