[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #911: MINIFICPP-1373 - Add proper FlowFile::getAttribute getter [QoL][mini-PR]

[GitBox <gi...@apache.org>]

hunyadi-dev commented on a change in pull request #911:
URL: https://github.com/apache/nifi-minifi-cpp/pull/911#discussion_r542227113



##########
File path: libminifi/include/core/FlowFile.h
##########
@@ -129,7 +130,9 @@ class FlowFile : public core::Connectable, public ReferenceContainer {
    * @param value value to set
    * @return result of finding key
    */
-  bool getAttribute(std::string key, std::string& value) const;
+  bool getAttribute(const std::string& key, std::string& value) const;
+
+  utils::optional<std::reference_wrapper<const std::string>> getAttribute(const std::string& key) const;

Review comment:
       One needs to call `.value().get()` or `->get()` on an optional of reference handlers. It indeed would be an issue if someone seriously misused `auto` for holding the return value, but otherwise this is even safer than returning a const ref.
   https://godbolt.org/z/jbhf3n
   
   Will change this to **return a copy**  :cry:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org