You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2015/06/04 22:47:52 UTC
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** open
**Milestone:** unreleased
**Labels:** performance
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Thu Jun 04, 2015 08:47 PM UTC
**Owner:** nobody
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: open --> review
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** review
**Milestone:** unreleased
**Labels:** performance sf-current sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 15, 2015 05:57 PM UTC
**Owner:** Heith Seewald
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Heith Seewald <hs...@slashdotmedia.com>.
Lowered the overall limit from 999999999 to 100k. Added a parameter to `ForgeMarkdown.convert` to bypass the char limit.
QA at **hs/7889**
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** open
**Milestone:** unreleased
**Labels:** performance sf-current sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 15, 2015 04:10 PM UTC
**Owner:** Heith Seewald
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: performance --> performance, sf-current, sf-2
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** open
**Milestone:** unreleased
**Labels:** performance sf-current sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Thu Jun 04, 2015 08:47 PM UTC
**Owner:** nobody
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **assigned_to**: Heith Seewald
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** open
**Milestone:** unreleased
**Labels:** performance sf-current sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 15, 2015 03:51 PM UTC
**Owner:** Heith Seewald
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: performance, sf-current, sf-2 --> performance, sf-2
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** closed
**Milestone:** unreleased
**Labels:** performance sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Tue Jun 16, 2015 03:59 PM UTC
**Owner:** Heith Seewald
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7889 Improve markdown logic for cached vs threshold limits
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
- **Reviewer**: Dave Brondsema
---
** [tickets:#7889] Improve markdown logic for cached vs threshold limits**
**Status:** closed
**Milestone:** unreleased
**Labels:** performance sf-current sf-2
**Created:** Thu Jun 04, 2015 08:47 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 15, 2015 06:02 PM UTC
**Owner:** Heith Seewald
The `markdown_render_max_length` param is an absolute limit to how big something can be for markdown conversion. But `cached_convert()` was added later and is a better approach. E.g. a very large ticket only has to get converted once and then its good, so a `markdown_render_max_length` isn't needed (we even have it set very high in development.ini because of this).
However, not all markdown conversions go through `cached_convert()`, for example, commit messages, outbound email bodies, or markdown files in repos.
So we should have `markdown_render_max_length` apply only to non-cached conversions and change its default value to something not so extremely high, maybe 100000. Or possibly introduce a second option, one for cached and one for non-cached conversions. Or develop a new caching mechanism that works for markdown text that isn't part of an artifact.
An example I came across was thousands of lines like this in the commit message itself, totaling around 500k chars:
~~~~
renamed: ts/5.1/fastboot/fastboot-mangle -> ts/5.2/fastboot/fastboot-mangle
renamed: ts/5.1/fastboot/lib-boot -> ts/5.2/fastboot/lib-boot
renamed: ts/5.1/fastboot/lib-rw -> ts/5.2/fastboot/lib-rw
renamed: ts/5.1/fastboot/usr-rw -> ts/5.2/fastboot/usr-rw
renamed: ts/5.1/kernel/alias/acpi -> ts/5.2/kernel/alias/acpi
renamed: ts/5.1/kernel/alias/pcm -> ts/5.2/kernel/alias/pcm
~~~~
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.