You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "AnvayKharb (via GitHub)" <gi...@apache.org> on 2026/07/05 14:37:04 UTC

[PR] Restore Templates API response shapes for Web App compatibility [fineract]

AnvayKharb opened a new pull request, #6092:
URL: https://github.com/apache/fineract/pull/6092

   
   Restores the Templates API response contract expected by the Mifos Web App.
   
   After FINERACT-2564, `GET /templates` returned id-only template objects and `GET /templates/{id}/template` returned raw template data instead of the wrapper used by the Web App. This caused WEB-1021: blank template list rows and a blank edit screen.
   
   ## Changes
   
   - Return full template data from `GET /templates`.
   - Restore `GET /templates/{id}/template` response wrapper with:
     - `entities`
     - `types`
     - `template`
   - Keep `GET /templates/{id}` as raw template data.
   - Map template `entity` and `type` as names, matching the previous API shape.
   - Add regression tests for list, edit wrapper, raw retrieval, mapper output, and query filtering.
   
   ## Testing
   
   - `./gradlew :fineract-provider:test --tests org.apache.fineract.template.api.TemplatesApiResourceTest --tests org.apache.fineract.template.mapper.TemplateMapperTest --tests org.apache.fineract.template.service.TemplateDomainServiceImplTest`
   - `./gradlew :fineract-provider:spotlessJavaCheck`
   
   Fixes WEB-1021.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "AnvayKharb (via GitHub)" <gi...@apache.org>.
AnvayKharb commented on PR #6092:
URL: https://github.com/apache/fineract/pull/6092#issuecomment-4934274993

   Hi @adamsaghy I've added the GPG key, please review again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #6092:
URL: https://github.com/apache/fineract/pull/6092


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #6092:
URL: https://github.com/apache/fineract/pull/6092#issuecomment-4905131476

   @adamsaghy @vidakovic LGTM. @vidakovic I would like to know the reason it was changed before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6092:
URL: https://github.com/apache/fineract/pull/6092#issuecomment-4929797075

   @AnvayKharb Please rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "AnvayKharb (via GitHub)" <gi...@apache.org>.
AnvayKharb commented on PR #6092:
URL: https://github.com/apache/fineract/pull/6092#issuecomment-4932219682

   Please review @IOhacker @adamsaghy @vidakovic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2675: Fix template endpoint [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6092:
URL: https://github.com/apache/fineract/pull/6092#issuecomment-4933740638

   @AnvayKharb Please make sure your commit is signed by GPG. I wont be able merge it till its done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org