You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Mladen Turk <mt...@apache.org> on 2008/04/19 18:31:19 UTC
Re: svn commit: r649830 - in /apr/apr/trunk: CHANGES include/apr_poll.h
poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c
mturk@apache.org wrote:
>
> URL: http://svn.apache.org/viewvc?rev=649830&view=rev
> Log:
> Introduce (again) apr_pollset_wakeup API
>
> Modified:
> apr/apr/trunk/CHANGES
> apr/apr/trunk/include/apr_poll.h
> apr/apr/trunk/poll/unix/epoll.c
> apr/apr/trunk/poll/unix/kqueue.c
> apr/apr/trunk/poll/unix/poll.c
> apr/apr/trunk/poll/unix/port.c
> apr/apr/trunk/poll/unix/select.c
>
Please note that I didn't test nor tried to compile
kqueue and port implementations (lack of tst platform).
They might have some copy/paste typos, so please either
fix directly or send me a patch and I'll commit.
Regards
--
(TM)
Re: svn commit: r649830 - in /apr/apr/trunk: CHANGES include/apr_poll.h
poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c
Posted by Mladen Turk <mt...@apache.org>.
Nick Kew wrote:
> Mladen Turk wrote:
>>
>> Please note that I didn't test nor tried to compile
>> kqueue and port implementations (lack of tst platform).
>> They might have some copy/paste typos, so please either
>> fix directly or send me a patch and I'll commit.
>
> @@ -304,21 +367,32 @@
> [chop]
>
> + if ((pollset->flags & APR_POLLSET_WAKEABLE) &&
> + fd.desc_type == APR_POLL_FILE &&
> + fd.desc.f == pollset->wakeup_pipe[0]) {
>
> I'm guessing fd is a typo for fp. Fixing - please
> shout if I've missed the point of something.
>
Right, it was an obvious typo.
Thanks Nick
Cheers
--
(TM)
Re: svn commit: r649830 - in /apr/apr/trunk: CHANGES
include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c
poll/unix/port.c poll/unix/select.c
Posted by Nick Kew <ni...@apache.org>.
Mladen Turk wrote:
> mturk@apache.org wrote:
>>
>> URL: http://svn.apache.org/viewvc?rev=649830&view=rev
>> Log:
>> Introduce (again) apr_pollset_wakeup API
>>
>> Modified:
>> apr/apr/trunk/CHANGES
>> apr/apr/trunk/include/apr_poll.h
>> apr/apr/trunk/poll/unix/epoll.c
>> apr/apr/trunk/poll/unix/kqueue.c
>> apr/apr/trunk/poll/unix/poll.c
>> apr/apr/trunk/poll/unix/port.c
>> apr/apr/trunk/poll/unix/select.c
>>
>
> Please note that I didn't test nor tried to compile
> kqueue and port implementations (lack of tst platform).
> They might have some copy/paste typos, so please either
> fix directly or send me a patch and I'll commit.
@@ -304,21 +367,32 @@
[chop]
+ if ((pollset->flags & APR_POLLSET_WAKEABLE) &&
+ fd.desc_type == APR_POLL_FILE &&
+ fd.desc.f == pollset->wakeup_pipe[0]) {
I'm guessing fd is a typo for fp. Fixing - please
shout if I've missed the point of something.
--
Nick Kew