You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Laxman Ch <la...@gmail.com> on 2017/01/05 22:00:50 UTC
Review/commit request
Hi,
Can some committers please review and commit the patches (FLUME-2894 and
FLUME-2894).
Also, I have a general question.
I see lot of issues (180+) were in PA state.
https://issues.apache.org/jira/browse/FLUME-3039?jql=resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%20AND%20status%20%3D%20%22Patch%20Available%22%20ORDER%20BY%20updatedDate%20DESC
Just wanted to know if the project is active enough to be used in
production cluster. Or is there any forked version by a vendor (like
cdh/hdp) which is active?
--
Thanks,
Laxman
Re: Review/commit request
Posted by Jeff Holoman <jh...@cloudera.com>.
To follow on here, Flume could really use some improvement in unit testing.
Generally speaking I'd like to see unit tests of some kind with any change.
Part of the issue is that many times making a change to something existing
isn't covered by a unit test, so we need to improve these as we go.
It makes it easier to get things committed if we don't have to manually
check things.
Thanks
Jeff
On Mon, Jan 9, 2017 at 8:25 AM, Bessenyei Balázs Donát <be...@apache.org>
wrote:
> Hi Laxman,
>
> I have left a comment on FLUME-2894. Please, let me know what you think.
> On FLUME-2984, simonati had a few questions.
>
> It is always great to hear about new users of Flume.
> Also, it is great you are interested in contributing back to Flume. Any
> help is super welcome (both patches and reviews).
>
> Unfortunately, some of those "patch available" tickets became outdated or
> need rebasing. There are a few of us who try to revisit and rebase those
> patches, but as I've said: any kind of help very much appreciated. (Ie.
> triaging, reviewing and rebasing.) If you can help with any of those, I'd
> be happy to commit them when they are ready. (We can even discuss them on
> the mailing list if you think that makes it easier.)
>
>
> Thank you,
>
> Donat
>
>
> 2017-01-07 17:53 GMT+01:00 Laxman Ch <la...@gmail.com>:
>
> > Thanks Donat and Jeff for your response. My patches in waiting
> > are FLUME-2894 and FLUME-2984
> >
> > We started using Flume recently in our organisation and we are using the
> > following components.
> > - Kafka Source, Kafka Channel, Kafka Sink
> > - Avro Source, Avro Sink
> > - Scribe Source
> > - Flume core
> >
> > We have done several fixes and improvements in the above components. We
> > would like to contribute back our patches to Flume. Also, I can
> contribute
> > to reviews (non-binding however) in these areas.
> >
> > And regarding health of the project, as I mentioned there are 180+ issues
> > in PatchAvailable state which is matching with big project like YARN. So,
> > does that call out for addition of few more active committers. Just a
> > thought.
> >
> >
> >
> > On 6 January 2017 at 18:36, Jeff Holoman <jh...@cloudera.com> wrote:
> >
> > > Yes we also had a release pretty recently. There are definitely some
> > > patches that need some attention, especially with reviews, and there
> is a
> > > backlog of work requests, but we have been continuing to add new
> > > functionality to the product.
> > >
> > > I'm also happy to take a look at the patches you mentioned.
> > >
> > > Thanks
> > >
> > > Jeff
> > >
> > > On Fri, Jan 6, 2017 at 6:05 AM, Bessenyei Balázs Donát <
> bessbd@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi Laxman,
> > > >
> > > > Unfortunately, I don't have the time to review all the patches
> > > > submitted and I have kind of fallen behind with Flume-related things
> > > > lately. If you have the interest and time in resuming work on those
> > > > patches, I'd be super happy to help!
> > > >
> > > > Anyways, if I get pinged on a ticket or PR, I do my best to
> prioritize
> > > > those. I'll take a look at FLUME-2894 asap. (Which one is the second
> > > > you'd like? I think you've mentioned FLUME-2894 twice.)
> > > >
> > > > On the activity: afaik, Flume should (still) be ready for use in
> > > > production and it's included with CDH (
> > > > http://www.cloudera.com/products/apache-hadoop/key-
> cdh-components.html
> > > > ) and HDP ( http://hortonworks.com/products/data-center/hdp/ ).
> > > >
> > > >
> > > > Best,
> > > >
> > > > Donat
> > > >
> > > > 2017-01-05 23:00 GMT+01:00 Laxman Ch <la...@gmail.com>:
> > > > > Hi,
> > > > >
> > > > > Can some committers please review and commit the patches
> (FLUME-2894
> > > and
> > > > > FLUME-2894).
> > > > >
> > > > > Also, I have a general question.
> > > > >
> > > > > I see lot of issues (180+) were in PA state.
> > > > > https://issues.apache.org/jira/browse/FLUME-3039?jql=
> > > > resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%
> > > > 20AND%20status%20%3D%20%22Patch%20Available%22%
> > > 20ORDER%20BY%20updatedDate%
> > > > 20DESC
> > > > >
> > > > > Just wanted to know if the project is active enough to be used in
> > > > > production cluster. Or is there any forked version by a vendor
> (like
> > > > > cdh/hdp) which is active?
> > > > >
> > > > > --
> > > > > Thanks,
> > > > > Laxman
> > > >
> > >
> >
> >
> >
> > --
> > Thanks,
> > Laxman
> >
>
Re: Review/commit request
Posted by Bessenyei Balázs Donát <be...@apache.org>.
Hi Laxman,
I have left a comment on FLUME-2894. Please, let me know what you think.
On FLUME-2984, simonati had a few questions.
It is always great to hear about new users of Flume.
Also, it is great you are interested in contributing back to Flume. Any
help is super welcome (both patches and reviews).
Unfortunately, some of those "patch available" tickets became outdated or
need rebasing. There are a few of us who try to revisit and rebase those
patches, but as I've said: any kind of help very much appreciated. (Ie.
triaging, reviewing and rebasing.) If you can help with any of those, I'd
be happy to commit them when they are ready. (We can even discuss them on
the mailing list if you think that makes it easier.)
Thank you,
Donat
2017-01-07 17:53 GMT+01:00 Laxman Ch <la...@gmail.com>:
> Thanks Donat and Jeff for your response. My patches in waiting
> are FLUME-2894 and FLUME-2984
>
> We started using Flume recently in our organisation and we are using the
> following components.
> - Kafka Source, Kafka Channel, Kafka Sink
> - Avro Source, Avro Sink
> - Scribe Source
> - Flume core
>
> We have done several fixes and improvements in the above components. We
> would like to contribute back our patches to Flume. Also, I can contribute
> to reviews (non-binding however) in these areas.
>
> And regarding health of the project, as I mentioned there are 180+ issues
> in PatchAvailable state which is matching with big project like YARN. So,
> does that call out for addition of few more active committers. Just a
> thought.
>
>
>
> On 6 January 2017 at 18:36, Jeff Holoman <jh...@cloudera.com> wrote:
>
> > Yes we also had a release pretty recently. There are definitely some
> > patches that need some attention, especially with reviews, and there is a
> > backlog of work requests, but we have been continuing to add new
> > functionality to the product.
> >
> > I'm also happy to take a look at the patches you mentioned.
> >
> > Thanks
> >
> > Jeff
> >
> > On Fri, Jan 6, 2017 at 6:05 AM, Bessenyei Balázs Donát <bessbd@gmail.com
> >
> > wrote:
> >
> > > Hi Laxman,
> > >
> > > Unfortunately, I don't have the time to review all the patches
> > > submitted and I have kind of fallen behind with Flume-related things
> > > lately. If you have the interest and time in resuming work on those
> > > patches, I'd be super happy to help!
> > >
> > > Anyways, if I get pinged on a ticket or PR, I do my best to prioritize
> > > those. I'll take a look at FLUME-2894 asap. (Which one is the second
> > > you'd like? I think you've mentioned FLUME-2894 twice.)
> > >
> > > On the activity: afaik, Flume should (still) be ready for use in
> > > production and it's included with CDH (
> > > http://www.cloudera.com/products/apache-hadoop/key-cdh-components.html
> > > ) and HDP ( http://hortonworks.com/products/data-center/hdp/ ).
> > >
> > >
> > > Best,
> > >
> > > Donat
> > >
> > > 2017-01-05 23:00 GMT+01:00 Laxman Ch <la...@gmail.com>:
> > > > Hi,
> > > >
> > > > Can some committers please review and commit the patches (FLUME-2894
> > and
> > > > FLUME-2894).
> > > >
> > > > Also, I have a general question.
> > > >
> > > > I see lot of issues (180+) were in PA state.
> > > > https://issues.apache.org/jira/browse/FLUME-3039?jql=
> > > resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%
> > > 20AND%20status%20%3D%20%22Patch%20Available%22%
> > 20ORDER%20BY%20updatedDate%
> > > 20DESC
> > > >
> > > > Just wanted to know if the project is active enough to be used in
> > > > production cluster. Or is there any forked version by a vendor (like
> > > > cdh/hdp) which is active?
> > > >
> > > > --
> > > > Thanks,
> > > > Laxman
> > >
> >
>
>
>
> --
> Thanks,
> Laxman
>
Re: Review/commit request
Posted by Laxman Ch <la...@gmail.com>.
Thanks Donat and Jeff for your response. My patches in waiting
are FLUME-2894 and FLUME-2984
We started using Flume recently in our organisation and we are using the
following components.
- Kafka Source, Kafka Channel, Kafka Sink
- Avro Source, Avro Sink
- Scribe Source
- Flume core
We have done several fixes and improvements in the above components. We
would like to contribute back our patches to Flume. Also, I can contribute
to reviews (non-binding however) in these areas.
And regarding health of the project, as I mentioned there are 180+ issues
in PatchAvailable state which is matching with big project like YARN. So,
does that call out for addition of few more active committers. Just a
thought.
On 6 January 2017 at 18:36, Jeff Holoman <jh...@cloudera.com> wrote:
> Yes we also had a release pretty recently. There are definitely some
> patches that need some attention, especially with reviews, and there is a
> backlog of work requests, but we have been continuing to add new
> functionality to the product.
>
> I'm also happy to take a look at the patches you mentioned.
>
> Thanks
>
> Jeff
>
> On Fri, Jan 6, 2017 at 6:05 AM, Bessenyei Balázs Donát <be...@gmail.com>
> wrote:
>
> > Hi Laxman,
> >
> > Unfortunately, I don't have the time to review all the patches
> > submitted and I have kind of fallen behind with Flume-related things
> > lately. If you have the interest and time in resuming work on those
> > patches, I'd be super happy to help!
> >
> > Anyways, if I get pinged on a ticket or PR, I do my best to prioritize
> > those. I'll take a look at FLUME-2894 asap. (Which one is the second
> > you'd like? I think you've mentioned FLUME-2894 twice.)
> >
> > On the activity: afaik, Flume should (still) be ready for use in
> > production and it's included with CDH (
> > http://www.cloudera.com/products/apache-hadoop/key-cdh-components.html
> > ) and HDP ( http://hortonworks.com/products/data-center/hdp/ ).
> >
> >
> > Best,
> >
> > Donat
> >
> > 2017-01-05 23:00 GMT+01:00 Laxman Ch <la...@gmail.com>:
> > > Hi,
> > >
> > > Can some committers please review and commit the patches (FLUME-2894
> and
> > > FLUME-2894).
> > >
> > > Also, I have a general question.
> > >
> > > I see lot of issues (180+) were in PA state.
> > > https://issues.apache.org/jira/browse/FLUME-3039?jql=
> > resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%
> > 20AND%20status%20%3D%20%22Patch%20Available%22%
> 20ORDER%20BY%20updatedDate%
> > 20DESC
> > >
> > > Just wanted to know if the project is active enough to be used in
> > > production cluster. Or is there any forked version by a vendor (like
> > > cdh/hdp) which is active?
> > >
> > > --
> > > Thanks,
> > > Laxman
> >
>
--
Thanks,
Laxman
Re: Review/commit request
Posted by Jeff Holoman <jh...@cloudera.com>.
Yes we also had a release pretty recently. There are definitely some
patches that need some attention, especially with reviews, and there is a
backlog of work requests, but we have been continuing to add new
functionality to the product.
I'm also happy to take a look at the patches you mentioned.
Thanks
Jeff
On Fri, Jan 6, 2017 at 6:05 AM, Bessenyei Balázs Donát <be...@gmail.com>
wrote:
> Hi Laxman,
>
> Unfortunately, I don't have the time to review all the patches
> submitted and I have kind of fallen behind with Flume-related things
> lately. If you have the interest and time in resuming work on those
> patches, I'd be super happy to help!
>
> Anyways, if I get pinged on a ticket or PR, I do my best to prioritize
> those. I'll take a look at FLUME-2894 asap. (Which one is the second
> you'd like? I think you've mentioned FLUME-2894 twice.)
>
> On the activity: afaik, Flume should (still) be ready for use in
> production and it's included with CDH (
> http://www.cloudera.com/products/apache-hadoop/key-cdh-components.html
> ) and HDP ( http://hortonworks.com/products/data-center/hdp/ ).
>
>
> Best,
>
> Donat
>
> 2017-01-05 23:00 GMT+01:00 Laxman Ch <la...@gmail.com>:
> > Hi,
> >
> > Can some committers please review and commit the patches (FLUME-2894 and
> > FLUME-2894).
> >
> > Also, I have a general question.
> >
> > I see lot of issues (180+) were in PA state.
> > https://issues.apache.org/jira/browse/FLUME-3039?jql=
> resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%
> 20AND%20status%20%3D%20%22Patch%20Available%22%20ORDER%20BY%20updatedDate%
> 20DESC
> >
> > Just wanted to know if the project is active enough to be used in
> > production cluster. Or is there any forked version by a vendor (like
> > cdh/hdp) which is active?
> >
> > --
> > Thanks,
> > Laxman
>
Re: Review/commit request
Posted by Bessenyei Balázs Donát <be...@gmail.com>.
Hi Laxman,
Unfortunately, I don't have the time to review all the patches
submitted and I have kind of fallen behind with Flume-related things
lately. If you have the interest and time in resuming work on those
patches, I'd be super happy to help!
Anyways, if I get pinged on a ticket or PR, I do my best to prioritize
those. I'll take a look at FLUME-2894 asap. (Which one is the second
you'd like? I think you've mentioned FLUME-2894 twice.)
On the activity: afaik, Flume should (still) be ready for use in
production and it's included with CDH (
http://www.cloudera.com/products/apache-hadoop/key-cdh-components.html
) and HDP ( http://hortonworks.com/products/data-center/hdp/ ).
Best,
Donat
2017-01-05 23:00 GMT+01:00 Laxman Ch <la...@gmail.com>:
> Hi,
>
> Can some committers please review and commit the patches (FLUME-2894 and
> FLUME-2894).
>
> Also, I have a general question.
>
> I see lot of issues (180+) were in PA state.
> https://issues.apache.org/jira/browse/FLUME-3039?jql=resolution%20%3D%20Unresolved%20AND%20project%20%3D%20FLUME%20AND%20status%20%3D%20%22Patch%20Available%22%20ORDER%20BY%20updatedDate%20DESC
>
> Just wanted to know if the project is active enough to be used in
> production cluster. Or is there any forked version by a vendor (like
> cdh/hdp) which is active?
>
> --
> Thanks,
> Laxman