You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 12:01:00 UTC
[jira] [Commented] (CAMEL-12448) camel-consul - service health
state calculated from all services with same name
[ https://issues.apache.org/jira/browse/CAMEL-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439339#comment-16439339 ]
ASF GitHub Bot commented on CAMEL-12448:
----------------------------------------
GitHub user player13 opened a pull request:
https://github.com/apache/camel/pull/2296
CAMEL-12448 - camel-consul: filter health checks by service id
In Consul catalog registered two instances of one service. Health check for first instance have "passed" state, and for second instance - "critical". Camel returns both service instances with healty checks, which method "isHealthy" returns "false".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/player13/camel CAMEL-12448
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2296
----
commit 4a521a1fba5ea432838d2d168f72bb7a2eec53b8
Author: Vadim R <83...@...>
Date: 2018-04-16T11:58:44Z
CAMEL-12448 - camel-consul: filter health checks by service id
----
> camel-consul - service health state calculated from all services with same name
> -------------------------------------------------------------------------------
>
> Key: CAMEL-12448
> URL: https://issues.apache.org/jira/browse/CAMEL-12448
> Project: Camel
> Issue Type: Bug
> Components: camel-consul
> Affects Versions: 2.21.0
> Reporter: Vadim R
> Priority: Major
>
> In Consul catalog registered two instances of one service. Health check for first instance have "passed" state, and for second instance - "critical". Camel returns both service instances with healty checks, which method "isHealthy" returns "false".
> I've make some changes in ConsulServiceDiscoveryTest to show up this bug, and fix it in ConsulServiceDiscovery.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)