You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2023/11/14 17:29:10 UTC
[PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… [incubator-uniffle]
guixiaowen opened a new pull request, #1312:
URL: https://github.com/apache/incubator-uniffle/pull/1312
… #1302
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Following this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
Using the ConfigOption to unify all client and server config style.
### Why are the changes needed?
Unify all client and server config style.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… [incubator-uniffle]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen closed pull request #1312: [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig…
URL: https://github.com/apache/incubator-uniffle/pull/1312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… [incubator-uniffle]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #1312:
URL: https://github.com/apache/incubator-uniffle/pull/1312#issuecomment-1810765268
Hi @zuston , could you please help reivew this pr , I may have lost some context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1312:
URL: https://github.com/apache/incubator-uniffle/pull/1312#issuecomment-1811839992
This change is not correct, the `configOption` has different params with `ConfigEntry`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1312:
URL: https://github.com/apache/incubator-uniffle/pull/1312#issuecomment-1813858550
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1312?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d5de299`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d5de2993f58060b7f2d719509eaed967ff137ad7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.35% compared to head [(`d367aac`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1312?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.81%.
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1312 +/- ##
============================================
+ Coverage 53.35% 53.81% +0.45%
+ Complexity 2690 2166 -524
============================================
Files 410 334 -76
Lines 23590 15088 -8502
Branches 2003 1389 -614
============================================
- Hits 12587 8119 -4468
+ Misses 10229 6516 -3713
+ Partials 774 453 -321
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1312?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org