You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/01/23 17:57:26 UTC
[kudu-CR] [util] omit '-b' option from lsof's invocations
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22380
Change subject: [util] omit '-b' option from lsof's invocations
......................................................................
[util] omit '-b' option from lsof's invocations
I haven't checked for the reason behind this, but at least with kernel
6.8.0 on Ubuntu 24.04.1 LTS, lsof doesn't list TCP sockets when running
with '-b' option (lsof version 4.95.0) like below:
lsof -wbnP -Fpfn -a -i 4TCP -p <pid>
Both TCP and UDP sockets are listed as expected when not adding
the '-b' option into the lsof's command line.
Removing the '-b' option shouldn't be a big deal since nothing
in the upstream CI pipeline runs on machines with NFS mounts or other
types of stale mounts that would block lstat(), readlink(), or stat()
system calls [1]. In any case, even if a process running as a part
of Kudu test scaffolding opens filesystem objects on a NFS mount,
the result of the test isn't quite predictable when the NFS mount
stalls, regardless of the lsof's behavior.
[1] https://www.man7.org/linux/man-pages/man8/lsof.8.html
Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
---
M src/kudu/client/client_examples-test.sh
M src/kudu/util/test_util.cc
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/22380/1
--
To view, visit http://gerrit.cloudera.org:8080/22380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Gerrit-Change-Number: 22380
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] omit '-b' option from lsof's invocations
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22380 )
Change subject: [util] omit '-b' option from lsof's invocations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Gerrit-Change-Number: 22380
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 24 Jan 2025 17:56:51 +0000
Gerrit-HasComments: No
[kudu-CR] [util] omit '-b' option from lsof's invocations
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22380 )
Change subject: [util] omit '-b' option from lsof's invocations
......................................................................
[util] omit '-b' option from lsof's invocations
I haven't checked for the reason behind this, but at least with kernel
6.8.0 on Ubuntu 24.04.1 LTS, lsof doesn't list TCP sockets when running
with '-b' option (lsof version 4.95.0) like below:
lsof -wbnP -Fpfn -a -i 4TCP -p <pid>
Both TCP and UDP sockets are listed as expected when not adding
the '-b' option into the lsof's command line.
Removing the '-b' option shouldn't be a big deal since nothing
in the upstream CI pipeline runs on machines with NFS mounts or other
types of stale mounts that would block lstat(), readlink(), or stat()
system calls [1]. In any case, even if a process running as a part
of Kudu test scaffolding opens filesystem objects on a NFS mount,
the result of the test isn't quite predictable when the NFS mount
stalls, regardless of the lsof's behavior.
[1] https://www.man7.org/linux/man-pages/man8/lsof.8.html
Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Reviewed-on: http://gerrit.cloudera.org:8080/22380
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/client/client_examples-test.sh
M src/kudu/util/test_util.cc
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Gerrit-Change-Number: 22380
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [util] omit '-b' option from lsof's invocations
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22380 )
Change subject: [util] omit '-b' option from lsof's invocations
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/954/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Gerrit-Change-Number: 22380
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 23 Jan 2025 18:56:23 +0000
Gerrit-HasComments: No
[kudu-CR] [util] omit '-b' option from lsof's invocations
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22380 )
Change subject: [util] omit '-b' option from lsof's invocations
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/954/
--
To view, visit http://gerrit.cloudera.org:8080/22380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73490a8f73728434292c5ee6f175eed63523ffd4
Gerrit-Change-Number: 22380
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Jan 2025 17:57:34 +0000
Gerrit-HasComments: No