You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gerhard Petracek (JIRA)" <de...@myfaces.apache.org> on 2011/08/30 18:13:38 UTC
[jira] [Issue Comment Edited] (EXTCDI-219) ConversationAware must
either be made public and moved to api or completely removed
[ https://issues.apache.org/jira/browse/EXTCDI-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093854#comment-13093854 ]
Gerhard Petracek edited comment on EXTCDI-219 at 8/30/11 4:12 PM:
------------------------------------------------------------------
we can move #setConversation to ConversationExpirationEvaluator but it doesn't make any difference because ConversationExpirationEvaluator is internal as well and not every ConversationExpirationEvaluator needs access to the conversation itself
this internal interface just exists because the conversation is needed in observeRenderedView which is a workaround to fix EXTCDI-49. all other conversation types don't need a ConversationExpirationEvaluator which is aware of the conversation.
was (Author: gpetracek):
we can move #setConversation to ConversationExpirationEvaluator but it doesn't make any difference because ConversationExpirationEvaluator is internal as well and not every ConversationExpirationEvaluator needs access to the conversation itself
> ConversationAware must either be made public and moved to api or completely removed
> -----------------------------------------------------------------------------------
>
> Key: EXTCDI-219
> URL: https://issues.apache.org/jira/browse/EXTCDI-219
> Project: MyFaces CODI
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Mark Struberg
> Assignee: Gerhard Petracek
> Priority: Minor
>
> ConversationAware is currently used internally for hardcoded casts. Either we make this interface public or drop it completely and add/subclass the functionality to ConversationExpirationEvaluator
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira