[GitHub] [buildstream] BenjaminSchubert commented on a change in pull request #1560: Fix shutdown of test server

[GitBox <gi...@apache.org>]

BenjaminSchubert commented on a change in pull request #1560:
URL: https://github.com/apache/buildstream/pull/1560#discussion_r784231341



##########
File path: tests/testutils/artifactshare.py
##########
@@ -67,7 +57,17 @@ def run(self, q):
             q.put(port)
 
             # Sleep until termination by signal
-            signal.pause()
+            signal.sigwait([signal.SIGTERM, signal.SIGINT])
+
+            server.stop(0)
+
+        # Save collected coverage data
+        try:
+            from pytest_cov.embed import cleanup
+        except ImportError:
+            pass
+        else:
+            cleanup()

Review comment:
       ```suggestion
           with suppress(ImportError):
               from pytest_cov.embed import cleanup
              cleanup()
   ```
   would that be more readable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org