You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2026/05/14 00:32:46 UTC
[PR] GH-49974: [C++][CMake] Add missing result variable initialization for `validate_apple_libtool()` [arrow]
kou opened a new pull request, #49975:
URL: https://github.com/apache/arrow/pull/49975
### Rationale for this change
`find_package()`'s `VALIDATOR`'s result variable must be initialized to `TRUE` by caller.
We reuse the `VALIDATOR` (`validate_apple_libtool()`) when we specify `CMAKE_LIBTOOL` explicitly. But we didn't initialize the result variable to `TRUE`.
### What changes are included in this PR?
Initialize `is_apple_libtool` explicitly.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49974: [C++][CMake] Add missing result variable initialization for `validate_apple_libtool()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49975:
URL: https://github.com/apache/arrow/pull/49975#issuecomment-4455761784
+1
Tested: https://github.com/apache/arrow/issues/49974#issuecomment-4454975557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49974: [C++][CMake] Add missing result variable initialization for `validate_apple_libtool()` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49975:
URL: https://github.com/apache/arrow/pull/49975#issuecomment-4463820834
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6d6f2468c22faad8418797279716de692b26701b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/76263525102) has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49974: [C++][CMake] Add missing result variable initialization for `validate_apple_libtool()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49975:
URL: https://github.com/apache/arrow/pull/49975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49974: [C++][CMake] Add missing result variable initialization for `validate_apple_libtool()` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49975:
URL: https://github.com/apache/arrow/pull/49975#issuecomment-4446294748
:warning: GitHub issue #49974 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org