You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/06 07:13:45 UTC

[GitHub] [iotdb] cornmonster opened a new pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

cornmonster opened a new pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913


   For more detailed descriptions: https://issues.apache.org/jira/browse/IOTDB-1629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-917770525


   > > Hi, How about fixing them both in this PR?
   > 
   > There is already another PR for https://issues.apache.org/jira/browse/IOTDB-1632, please see: #3914
   > 
   > This PR should pass the CI tests once PR #3914 merged.
   
   OK!You can do it now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42669842/badge)](https://coveralls.io/builds/42669842)
   
   Coverage decreased (-0.02%) to 67.359% when pulling **a2bb869e8081984f1a2f124c3003e968a4caabf1 on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42670017/badge)](https://coveralls.io/builds/42670017)
   
   Coverage increased (+0.03%) to 67.404% when pulling **a2bb869e8081984f1a2f124c3003e968a4caabf1 on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-916601394


   > Hi, How about fixing them both in this PR?
   
   There is already another PR for https://issues.apache.org/jira/browse/IOTDB-1632, please see: https://github.com/apache/iotdb/pull/3914
   
   This PR should pass the CI tests once PR #3914 merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913434503


   Hi, thanks for your contribution!
   
   How about adding some UT or IT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913493189


   > Hi, thanks for your contribution!
   > 
   > How about adding some UT or IT?
   
   
   > Hi, thanks for your contribution!
   > 
   > How about adding some UT or IT?
   
   Sure. But this issue is related to another one, please see https://issues.apache.org/jira/browse/IOTDB-1632. The value fill function currently produces incorrect results, and that's why the unit test fails right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] mychaow commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-918709033


   please cherry pick to 0.12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl merged pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
LebronAl merged pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42672983/badge)](https://coveralls.io/builds/42672983)
   
   Coverage increased (+0.004%) to 67.38% when pulling **182d59fd9b92cb511819f72941427a833e730b6c on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42814509/badge)](https://coveralls.io/builds/42814509)
   
   Coverage decreased (-0.1%) to 67.384% when pulling **a0168f95c0a8c2a58d3a120826e0d83ec80787a0 on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **b76a799c4346ba16caf468e0c8f191949ff612b4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42814878/badge)](https://coveralls.io/builds/42814878)
   
   Coverage decreased (-0.1%) to 67.374% when pulling **a0168f95c0a8c2a58d3a120826e0d83ec80787a0 on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **b76a799c4346ba16caf468e0c8f191949ff612b4 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] LebronAl commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-916595356


   Hi, How about fixing them both in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-917812713


   > Do you think that we need a `ClusterValueFill` just like `ClusterLinearFill` and `ClusterPreviousFill`?
   
   Nope, I believe we have `ClusterLinearFill` and `ClusterPreviousFill` because they need to access the storage engine, and the way of accessing the storage engine in cluster mode is different from the standalone mode. ValueFill doesn't require any context except the input constant, so implementing the `ClusterValueFill` may not be necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913433600


   
   [![Coverage Status](https://coveralls.io/builds/42673556/badge)](https://coveralls.io/builds/42673556)
   
   Coverage remained the same at 67.376% when pulling **182d59fd9b92cb511819f72941427a833e730b6c on cornmonster:fix_NPE_from_fillqueryexecutor_in_cluster_mode** into **3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster edited a comment on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
cornmonster edited a comment on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-913493189


   > Hi, thanks for your contribution!
   > 
   > How about adding some UT or IT?
   
   
   Sure. But this issue is related to another one, please see https://issues.apache.org/jira/browse/IOTDB-1632. The value fill function currently produces incorrect results, and that's why the unit test fails right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #3913: [IOTDB-1629] fix the NPE when using value fill in cluster mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #3913:
URL: https://github.com/apache/iotdb/pull/3913#issuecomment-917801847


   > > > Hi, How about fixing them both in this PR?
   > > 
   > > 
   > > There is already another PR for https://issues.apache.org/jira/browse/IOTDB-1632, please see: #3914
   > > This PR should pass the CI tests once PR #3914 merged.
   > 
   > OK!You can do it now!
   
   Thanks! I have rebased the code and all tests are passing now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org