You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/10/21 04:35:40 UTC
[GitHub] zeppelin pull request #1545: ZEPPELIN-1571. Support pig udf interpreter
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1545
ZEPPELIN-1571. Support pig udf interpreter
### What is this PR for?
Support a new interpreter `%pig.udf` for Pig Interpreter group. User can write pig udf in this interpreter, and will compile/build this udf to jar which would be registered in pig automatically.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1571
### How should this be tested?
Unit test is added
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1571
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1545
----
commit 9ebabbb8b09ca8e52623e48b4616bc01e0be5e3a
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-10-20T14:30:54Z
ZEPPELIN-1571. Support pig udf interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by Malian <gi...@git.apache.org>.
Github user Malian commented on the issue:
https://github.com/apache/zeppelin/pull/1545
@zjffdu What's the status of this pull request ? Can we expect it will be merged soon ? Thank you !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1545
@zjffdu Sadly there are some conflicts now. Could you resolve them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1545
js file for java syntax highlight(`mode-java.js`) is never used before so you will need to import it first.
Here are the files where `mode-java.js` should be added:
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/index.html#L123
https://github.com/apache/zeppelin/blob/master/zeppelin-web/bower.json#L51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1545
Thanks @minahlee It works now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1545
2 comments, LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1545: [WIP] ZEPPELIN-1571. Support pig udf interprete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1545
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1545
@felixcheung @AhyoungRyu Please help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: [WIP] ZEPPELIN-1571. Support pig udf interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1545
@AhyoungRyu @felixcheung I changed this PR to WIP. As there's still one issue I need to fix. The issue is that if user change the udf, the class can not been reloading unless restarting the interpreter. I need to fix this classloading issue in pig side first, then I will continue this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1545
@minahlee The syntax highlight for java doesn't work, could you help to check what's I missing here ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---