You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by pke <gi...@git.apache.org> on 2015/10/27 12:38:21 UTC
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
GitHub user pke opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/42
Feature add is simulator for windows
This adds the `isVirtual` for the Windows 8.x Desktop and Phone platforms.
Virtual means the app is running in the Windows Simulator (a remote session) or the Windows Phone/Mobile Emulator.
I also simplified the retrieval of the device manufacture name by using ?`` `Windows.Security.ExchangeActiveSyncProvisioning.EasClientDeviceInformation`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pke/cordova-plugin-device feature-add-is-simulator-for-windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 05787ac65b71988b360c367521c82897f006fe40
Author: Philipp Kursawe <ph...@gmail.com>
Date: 2015-10-27T11:34:24Z
Add `isVirtual` for Windows 8.x (Phone) platforms
Sets `isVirtual` to true when:
- Running in Simulator on Windows 8.x/10
- Running in Windows Phone 8.x Emulator
This also uses the `Windows.Security.ExchangeActiveSyncProvisioning.EasClientDeviceInformation` to get the manufacturer instead of querying this from the PnP devices.
Not tested with Windows 10 Mobile Emulator, but should be the same as Windows 8.1 Phone.
commit d695f7dfef2689d1caa5f4796a0aea1339b3e2ee
Author: Philipp Kursawe <ph...@gmail.com>
Date: 2015-10-27T11:34:44Z
fix whitespace tab to spaces
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151661702
Sweet! Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by pke <gi...@git.apache.org>.
Github user pke commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-152016809
@purplecabbage The Secretary of the Apache Software Foundation has informed me that my ICLA has been filed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by pke <gi...@git.apache.org>.
Github user pke commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151662637
No problem. It's about time Cordova gets a little Windows love ;)
More is in the pipeline: `device.name`, fast QR code scanner (the current is way too slow on Windows Phone)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by pke <gi...@git.apache.org>.
Github user pke commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151661223
@purplecabbage its on its way already :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151642202
Awesome contribution @pke thanks!
Can you please send an ICLA as explained here: https://cordova.apache.org/contribute/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org