[GitHub] [guacamole-client] jmuehlner commented on a change in pull request #616: GUACAMOLE-773: Update all JavaScript dependencies to latest versions.

[GitBox <gi...@apache.org>]

jmuehlner commented on a change in pull request #616:
URL: https://github.com/apache/guacamole-client/pull/616#discussion_r644447944



##########
File path: guacamole/src/main/frontend/package.json
##########
@@ -0,0 +1,35 @@
+{
+    "private": true,
+    "scripts": {
+        "build": "webpack --progress"
+    },
+    "dependencies": {
+        "@simonwep/pickr": "1.8.1",
+        "angular": "1.8.2",
+        "angular-route": "1.8.2",
+        "angular-templatecache-webpack-plugin": "^1.0.1",

Review comment:
       Do we plan on having any policy on whether these dependencies should use the `^` operator or not? The `package-lock.json` ensures that builds will be repeatable, but I usually like to lock down the packages to specific versions by removing the `^` and other operators out of `package.json` as well.
   
   I'm not really sure what the right call is here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org