You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/08/30 21:50:44 UTC

[GitHub] [trafficcontrol] TaylorCFrey opened a new pull request, #7050: Add configuration setting for TO client request timeout

TaylorCFrey opened a new pull request, #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050

   Closes: #7048 
   
   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - Documentation
   - Traffic Stats
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your PR.
   If your PR has tests (and most should), provide the steps needed to run the tests.
   If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
   
   Ensure the all tests (especially CDN-in-a-box) continues to work and run. Traffic Stats should run whether the configuration value is present or not. It will default to the previous hard coded 10 seconds. However, now it should also accept the new "toRequestTimeout" value in the .cfg file.
   
   As this requires an unresponsive/slow TO instance, testing can be difficult. This can be done locally with a debug build and breakpoints. You can put a breakpoint at the beginning of the TO GET v3.1/servers endpoint and waiting longer the alloted time (be it the 10 second default or whatever custom value you place) which will prevent Traffic Stats from receiving a response in time and cause the error to appear in the log. The error is:
   
   ```
   [ERROR] 2022-08-30 14:36:10 Error getting server list from https://{{traffic_ops_url}}/: Get "https://{{traffic_ops_url}}/api/3.1/servers": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
   ```
   
   The next time through you can remove the breakpoint and allow it to proceed normally. The error will not appear and TS will function normally.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
   Examples:
   - 5.1.2
   - 5.1.3 (RC1)
    -->
   
   
   ## PR submission checklist
   - [ ] This PR has tests - Traffic Stats has minimal testing support and would require significant refactoring for this test.
   - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7050: Add configuration setting for TO client request timeout

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on code in PR #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050#discussion_r992726936


##########
infrastructure/ansible/roles/traffic_stats/templates/traffic_stats.cfg.j2:
##########
@@ -15,6 +15,7 @@
         "toUser": "{{ ts_toUser }}",
         "toPasswd": "{{ ts_toPasswd }}",
         "toUrl": "{{ ts_toUrl }}",
+        "toRequestTimeout": "{{ ts_toRequestTimeout }}",

Review Comment:
   if it's a number you don't need them. The others look like they're strings, so they do need them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] TaylorCFrey commented on a diff in pull request #7050: Add configuration setting for TO client request timeout

Posted by GitBox <gi...@apache.org>.
TaylorCFrey commented on code in PR #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050#discussion_r991675941


##########
infrastructure/ansible/roles/traffic_stats/templates/traffic_stats.cfg.j2:
##########
@@ -15,6 +15,7 @@
         "toUser": "{{ ts_toUser }}",
         "toPasswd": "{{ ts_toPasswd }}",
         "toUrl": "{{ ts_toUrl }}",
+        "toRequestTimeout": "{{ ts_toRequestTimeout }}",

Review Comment:
   I don't believe so. It follows the same formatting as all of the previous fields. Unless I'm not seeing it correctly...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] srijeet0406 merged pull request #7050: Add configuration setting for TO client request timeout

Posted by GitBox <gi...@apache.org>.
srijeet0406 merged PR #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org