[GitHub] [ozone] xiaoyuyao commented on a change in pull request #1888: HDDS-4787.Trash emptier fails to create checkpoints in a secure setup

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1888:
URL: https://github.com/apache/ozone/pull/1888#discussion_r569787990



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3605,14 +3620,20 @@ public ResolvedBucket resolveBucketLink(Pair<String, String> requested)
       throws IOException {
 
     Pair<String, String> resolved;
-    if (isAclEnabled) {
-      resolved = resolveBucketLink(requested, new HashSet<>(),
-              Server.getRemoteUser(),
-              Server.getRemoteIp(),
-              Server.getRemoteIp().getHostName());
-    } else {
-      resolved = resolveBucketLink(requested, new HashSet<>(),
-          null, null, null);
+    try {
+      if (isAclEnabled) {

Review comment:
       agree with @adoroszlai can we use a local variable to hold the result of Server.getRemoteIp().




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org