[GitHub] [carbondata] lamber-ken commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code

[GitBox <gi...@apache.org>]

lamber-ken commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code
URL: https://github.com/apache/carbondata/pull/3391#discussion_r326898976
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -81,7 +81,7 @@ private CarbonCommonConstants() {
    * default carbon properties file path
    */
   public static final String CARBON_PROPERTIES_FILE_PATH_DEFAULT =
-      "../../../conf/carbon.properties";
 
 Review comment:
   hi, I got your point. But may be most user don't use this defalut value, because `../../../` means the property file was placed at three-tier parent directory.
   If you still stick to your point of view, I am also willing to revert it, thanks.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services