You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/12/02 16:02:22 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #20767: Fix identity fuse
bgawrych opened a new pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767
## Description ##
During testing https://github.com/dmlc/gluon-nlp/pull/1581 it occurred that identity fuse doesn't work properly on big graph, but works in unit test - that was caused by lack of stop condition in subgraph selector.
This PR fix this issue and expand test to cover such cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-995541890
Jenkins CI successfully triggered : [unix-gpu, centos-cpu, unix-cpu, clang, centos-gpu, sanity, windows-gpu, edge, windows-cpu, miscellaneous, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-986499435
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-985268770
Jenkins CI successfully triggered : [unix-cpu, centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-986499355
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-995541796
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-986801772
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-985502090
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-985268700
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-985502161
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on a change in pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on a change in pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#discussion_r766527196
##########
File path: src/operator/subgraph/dnnl/dnnl_identity_property.h
##########
@@ -65,10 +66,11 @@ class SgDNNLIdentitySelector : public SubgraphSelectorV2 {
}
bool SelectInput(const BiDirectedNode& n, const BiDirectedNode& input_node) override {
- if (input_node.node->is_variable()) {
+ if (pattern_found || input_node.node->is_variable()) {
Review comment:
You could use `matched_list_` like you did in the `Filter` function.
```suggestion
if (matched_list_.size() == 2 || input_node.node->is_variable()) {
```
If not, then I would also use `pattern_found` in the `Filter` function, to show, that these conditions are connected.
https://github.com/apache/incubator-mxnet/blob/7e163157cf789d7ec5e7272532e04495e57bd0ba/src/operator/subgraph/dnnl/dnnl_identity_property.h#L85
Change to :
```
if (pattern_found && candidates.size() == matched_list_.size()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on a change in pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#discussion_r770310841
##########
File path: src/operator/subgraph/dnnl/dnnl_identity_property.h
##########
@@ -65,10 +66,11 @@ class SgDNNLIdentitySelector : public SubgraphSelectorV2 {
}
bool SelectInput(const BiDirectedNode& n, const BiDirectedNode& input_node) override {
- if (input_node.node->is_variable()) {
+ if (pattern_found || input_node.node->is_variable()) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20767: Fix identity fuse for oneDNN
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-986801678
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20767: Fix identity fuse
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20767:
URL: https://github.com/apache/incubator-mxnet/pull/20767#issuecomment-984765241
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, windows-gpu, website, unix-gpu, miscellaneous, sanity, edge, centos-gpu, windows-cpu, clang, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org