You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/12/21 06:31:54 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new issue, #443: [Improvement] refactor getPartitionRange to calculate range directly
advancedxy opened a new issue, #443:
URL: https://github.com/apache/incubator-uniffle/issues/443
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
ShuffleStorageUtils.getPartitionRange is not performant...
It could be calculated directly in O(1).. However current impl is about O(n) where n is the number of partition ranges. when partition range size =1, n is corresponding to partition numbers.
### How should we improve?
refactor `ShuffleStorageUtils.getPartitionRange` to calculate range directly.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] a-li commented on issue #443: [Improvement] refactor getPartitionRange to calculate range directly
Posted by GitBox <gi...@apache.org>.
a-li commented on issue #443:
URL: https://github.com/apache/incubator-uniffle/issues/443#issuecomment-1364334602
Hey I’m looking to contribute to Uniffle and would like to try to do this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #443: [Improvement] refactor getPartitionRange to calculate range directly
Posted by GitBox <gi...@apache.org>.
advancedxy commented on issue #443:
URL: https://github.com/apache/incubator-uniffle/issues/443#issuecomment-1360912130
Related context: https://github.com/apache/incubator-uniffle/pull/424#discussion_r1050655270
I would leave it open until next week, so someone who want to make a contribution, can start with this small improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #443: [Improvement] refactor getPartitionRange to calculate range directly
Posted by GitBox <gi...@apache.org>.
advancedxy commented on issue #443:
URL: https://github.com/apache/incubator-uniffle/issues/443#issuecomment-1364451129
@a-li thanks, I’ve assigned it to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy closed issue #443: [Improvement] refactor getPartitionRange to calculate range directly
Posted by GitBox <gi...@apache.org>.
advancedxy closed issue #443: [Improvement] refactor getPartitionRange to calculate range directly
URL: https://github.com/apache/incubator-uniffle/issues/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org