You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/05/09 17:20:07 UTC

[Impala-ASF-CR] IMPALA-6645: Enable disk spill encryption by default

Hello Dan Hecht, Kim Jin Chul, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10345

to look at the new patch set (#4).

Change subject: IMPALA-6645: Enable disk spill encryption by default
......................................................................

IMPALA-6645: Enable disk spill encryption by default

Perf:
Targeted benchmarks with a heavily spilling query on a machine
with PCLMULQDQ support show < 5% of CPU time spent in encryption and
decryption. PCLMULQDQ was introduced in AMD Bulldozer (c. 2011)
and Intel Westmere (c. 2010).

Testing:
Ran core tests with the change.

Updated the custom cluster test to exercise the non-default
configuration.

Change-Id: Iee4be2a95d689f66c3663d99e4df0fb3968893a9
---
M be/src/runtime/tmp-file-mgr.cc
R testdata/workloads/functional-query/queries/QueryTest/basic-spilling.test
R tests/custom_cluster/test_disk_spill_configurations.py
3 files changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/10345/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee4be2a95d689f66c3663d99e4df0fb3968893a9
Gerrit-Change-Number: 10345
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>