Re: [PR] fix: preserve correct column order when table layout is changed with time comparison enabled [superset]

["msyavuz (via GitHub)" <gi...@apache.org>]

msyavuz commented on code in PR #34300:
URL: https://github.com/apache/superset/pull/34300#discussion_r2229869443


##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -629,7 +629,11 @@ export default function TableChart<D extends DataRecord = DataRecord>(
       const startPosition = value[0];
       const colSpan = value.length;
       // Retrieve the originalLabel from the first column in this group
-      const originalLabel = columnsMeta[value[0]]?.originalLabel || key;
+      const firstColumnInGroup = filteredColumnsMeta[value[0]];

Review Comment:
   Can't we use startPosition here?
   ```suggestion
         const firstColumnInGroup = filteredColumnsMeta[startPosition];
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org