You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2023/09/19 14:50:00 UTC

[jira] [Commented] (YUNIKORN-1980) deprecated log REST calls to return 410 (Gone)

    [ https://issues.apache.org/jira/browse/YUNIKORN-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766829#comment-17766829 ] 

Craig Condit commented on YUNIKORN-1980:
----------------------------------------

I think we should remove these entirely if we're going to do anything. Changing the response code is just as much of a breaking change as removing them. The "info" response was added in 1.3 to allow older tools to not break, as the log level is no longer a single value.

If we're going to break compatibility in 1.4, let's go all the way and get rid of the dead code. A 404 (the default) is just as good as a 410.

> deprecated log REST calls to return 410 (Gone)
> ----------------------------------------------
>
>                 Key: YUNIKORN-1980
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1980
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - common
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Kuan-Po Tseng
>            Priority: Major
>              Labels: newbie
>
> The {{{}/ws/v1/loglevel/{level{}}}} and {{/ws/v1/loglevel}} calls are currently broken.
> {{/ws/v1/loglevel}} always returns "info" regardless of what is set. It does not take into account the new scoped logging. We either need to fix that or not return anything and send back a 410 Gone response.
> Setting a log level always return a 200 OK without doing anything. We should respond with a 410 Gone response.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org