You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2025/02/08 13:35:32 UTC
[PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
kezhenxu94 opened a new pull request, #188:
URL: https://github.com/apache/skywalking-eyes/pull/188
Dependencies license check depends on different programming language env and version, it’s unreasonable to include the env in the Docker image by default, this PR cleans the programming language tools from the Docker images to reduce the size from 350+M to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645695085
> `from 350+M to`?
Updated the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#discussion_r1947825797
##########
examples/golang/Dockerfile:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM apache/skywalking-eyes:latest
Review Comment:
How about we push `version:latest-go-deps` image as well to make it convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645717404
`350+M to ~36M` It seems this is worth a new release. Just wonder whether https://github.com/apache/skywalking-eyes/pull/188#discussion_r1947825797 is worth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645724249
> Meanwhile, for our own user case, the main repo seems to require Java and Node to do dependency analysis, right? How are we going to support that?
Simple. We are not using Docker to do that, we use the binary executable right in the system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645727837
People who want to use dependencies check with Docker in their projects , they need to build their docker image based on the license-eye docker image, that would be a case by case scenario, some might need to install all of Go 1.19, Java, and npm, some might just need Go 1.23, I'm not going to release an image that contains these various tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#discussion_r1947830302
##########
examples/golang/Dockerfile:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM apache/skywalking-eyes:latest
Review Comment:
> How about we push `version:latest-go-deps` image as well to make it convenient?
I'm not sure whether it'll be convenient, people might be using different go version and it does not make things much better unless we want to push tens of tags for each Go version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645717741
Meanwhile, for our self user case, the main repo seems to require Java and Node to do dependency analysis, right? How are we going to support that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#issuecomment-2645655980
`from 350+M to`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump up to go 1.23 and clean up Docker images [skywalking-eyes]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #188:
URL: https://github.com/apache/skywalking-eyes/pull/188#discussion_r1947830302
##########
examples/golang/Dockerfile:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM apache/skywalking-eyes:latest
Review Comment:
> How about we push `version:latest-go-deps` image as well to make it convenient?
I'm not sure whether it'll be convenient, people might be using different go version and it does not make things much better unless we want to push tens of tags for each version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org