[GitHub] [kafka] fqaiser94 commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

["fqaiser94 (via GitHub)" <gi...@apache.org>]

fqaiser94 commented on code in PR #10747:
URL: https://github.com/apache/kafka/pull/10747#discussion_r1125795728


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -398,6 +398,12 @@ public class StreamsConfig extends AbstractConfig {
     @SuppressWarnings("WeakerAccess")
     public static final String UPGRADE_FROM_33 = "3.3";
 
+    /**
+     * Config value for parameter {@link #UPGRADE_FROM_CONFIG "upgrade.from"} for upgrading an application from version {@code 3.4.x}.
+     */
+    @SuppressWarnings("WeakerAccess")
+    public static final String UPGRADE_FROM_34 = "3.4";
+

Review Comment:
   Not sure if it's appropriate to make this change in this PR. 
   It _seems_ to me that the last step of the [Release Process](https://cwiki.apache.org/confluence/x/NqETAg) hasn't yet been completed for Kafka 3.4.0: 
   > For feature releases, file a JIRA for updating compatibility/upgrade system tests to test the newly released version. Example PRs:
   > - Broker and clients: https://github.com/apache/kafka/pull/12210
   > - Streams: https://github.com/apache/kafka/pull/12209
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org